Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alphabetical key shortcuts. #866

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

guibarrette
Copy link
Contributor

@guibarrette guibarrette commented Jul 22, 2021

Fix alphabetical key shortcuts. A SHIFT modifier key was registered by accident since the keyLabel from a LogicalKeyboardKey in Flutter changed to an upper case value

Fixes #865

…y accident since the keyLabel from a LogicalKeyboardKey in Flutter changed to an upper case value
@google-cla
Copy link

google-cla bot commented Jul 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@guibarrette
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan stuartmorgan merged commit a8ca32b into google:master Jul 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[menubar] Bug: Shortcuts using alphabetical keys have an extra SHIFT modifier key registered
2 participants