Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add Android plugin for Text #2

Closed
wants to merge 17 commits into from
Closed

Conversation

craiglabenz
Copy link
Collaborator

@craiglabenz craiglabenz commented May 16, 2023

Description

Adds the beginning scaffolding for the mediapipe_task_text library, including the mediapipe_task_text_platform_implementation and mediapipe_task_text_android libraries.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@PaulTR
Copy link
Collaborator

PaulTR commented May 16, 2023

We should probably move the app in example down a layer since the text plugin includes things like text classification, language detector, and text embedding.

@craiglabenz
Copy link
Collaborator Author

We should probably move the app in example down a layer since the text plugin includes things like text classification, language detector, and text embedding.

Do you think it's important to have separate samples for each work flow, or could they potentially be lumped into one demo with 3 different buttons to complete each task?

@PaulTR
Copy link
Collaborator

PaulTR commented May 29, 2023 via email

@PaulTR
Copy link
Collaborator

PaulTR commented May 30, 2023

Also let's keep it simple and only have one sample to start per category. For Android we did text classification, audio classification, and object detection. We can flesh out the remainders via GSoC and my own development once we have a rough template so you're not spending all of your time on samples. Core functionality is definitely the priority, and I can focus on details/polish.

@craiglabenz
Copy link
Collaborator Author

The latest commit should be working (or at least close to) from an implementation standpoint, but I'm getting segfault-like errors in my Android emulator.

@craiglabenz
Copy link
Collaborator Author

So obsolete, you can't even imagine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants