-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final pre-publish housekeeping #32
Conversation
MediaPipe packages are all now pure-Dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more to fix:
Analyzing mediapipe-core...
warning - lib/src/io/containers.dart:72:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:84:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:134:15 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:158:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:240:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:260:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:261:34 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:278:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:279:36 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/task_result.dart:41:15 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/task_result.dart:66:42 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
It turns out I hadn't run |
As far as I can tell, these latest integration test failures are a false-positive. They passed until recently in CI and still pass locally. |
native_assets_cli: ^0.3.0 | ||
native_toolchain_c: ^0.3.0 | ||
path: ^1.8.3 | ||
|
||
dev_dependencies: | ||
ffigen: ^9.0.1 | ||
flutter_lints: ^2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DBC: If I'm not mistaken the list of flutter lints is bigger than the lints package. So you might as well keep flutter_lints if you don't mind satisfying them. It makes the code more pleasant to read to typical flutter users. (And flutter_lints doesn't require a flutter SDK.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that's a hot tip!
test failures in CI are from dart-lang/sdk#55712
Merging as test failures are false positives from dart-lang/sdk#55712 |
flutter_lints
tolints
mediapipe_core
to0.0.1
(already published)