Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final pre-publish housekeeping #32

Merged
merged 10 commits into from
May 14, 2024
Merged

Final pre-publish housekeeping #32

merged 10 commits into from
May 14, 2024

Conversation

craiglabenz
Copy link
Collaborator

  • Removed dependency on Flutter from packages - all are now pure-Dart
    • Various linting changes (removing redundant null-check operators) that emerged by moving from flutter_lints to lints
  • Moved dependencies on mediapipe_core to 0.0.1 (already published)
  • Added supported platforms declaration
  • Added MediaPipe's license files

Copy link
Member

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more to fix:

Analyzing mediapipe-core...

warning - lib/src/io/containers.dart:72:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:84:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:134:15 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:158:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:240:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:260:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:261:34 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:278:19 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/containers.dart:279:36 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/task_result.dart:41:15 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
warning - lib/src/io/task_result.dart:66:42 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion

@craiglabenz
Copy link
Collaborator Author

craiglabenz commented May 13, 2024

Odd that my editor didn't tell me about those... 🤔

It turns out I hadn't run dart pub get since bumping the SDK requirements above 3.2, which is when private field promotion arrived.

@craiglabenz
Copy link
Collaborator Author

As far as I can tell, these latest integration test failures are a false-positive. They passed until recently in CI and still pass locally.

native_assets_cli: ^0.3.0
native_toolchain_c: ^0.3.0
path: ^1.8.3

dev_dependencies:
ffigen: ^9.0.1
flutter_lints: ^2.0.0
Copy link
Member

@dcharkes dcharkes May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DBC: If I'm not mistaken the list of flutter lints is bigger than the lints package. So you might as well keep flutter_lints if you don't mind satisfying them. It makes the code more pleasant to read to typical flutter users. (And flutter_lints doesn't require a flutter SDK.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's a hot tip!

@craiglabenz
Copy link
Collaborator Author

Merging as test failures are false positives from dart-lang/sdk#55712

@craiglabenz craiglabenz merged commit cdc31fe into main May 14, 2024
2 of 3 checks passed
@craiglabenz craiglabenz deleted the pre-publish branch May 14, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants