When itemCount is zero it executes builder with index 0 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamesderlin @mehmetf |
|
lgtm |
|
I see that tests are failing due to the strange error... |
|
@tarobins could you please apply this internally and verify? Once it is submitted to google3, we can push it upstream as well. |
jamesderlin
pushed a commit
that referenced
this pull request
Apr 2, 2020
…with index 0 When `itemCount` is zero it executes builder with index 0 which is slightly wrong cause there is no items) This PR fixes that unexpected behaviour and adds test for an empty list. Closes #79 PiperOrigin-RevId: 304429846
|
@mehmetf @vasilich6107 I believe @jamesderlin is taking care of this issue for us, and you'll see his pr above. Thanks @jamesderlin |
jamesderlin
pushed a commit
that referenced
this pull request
Apr 2, 2020
…with index 0 When `itemCount` is zero it executes builder with index 0 which is slightly wrong cause there is no items) This PR fixes that unexpected behaviour and adds test for an empty list. Closes #79 PiperOrigin-RevId: 304429846
|
thanks @vasilich6107 for the pr |
Zony-Zhao
pushed a commit
to Zony-Zhao/scrollable_positioned_list
that referenced
this pull request
Sep 28, 2020
…with index 0 When `itemCount` is zero it executes builder with index 0 which is slightly wrong cause there is no items) This PR fixes that unexpected behaviour and adds test for an empty list. Closes google/flutter.widgets#79 PiperOrigin-RevId: 304429846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
itemCountis zero it executes builder with index 0 which is slightly wrong cause there is no items) This PR fixes that unexpected behaviour and adds test for an empty list.Related Issues
#78
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter testpass.flutter analyzedoes not report any problems on my PR.