Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'isFixedPitch' flag not set for Roboto Mono #225

Open
NAKlama opened this issue Mar 11, 2016 · 23 comments
Open

'isFixedPitch' flag not set for Roboto Mono #225

NAKlama opened this issue Mar 11, 2016 · 23 comments
Assignees
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I Font Bug

Comments

@NAKlama
Copy link

NAKlama commented Mar 11, 2016

This prevents the font to be used on Windows.
Workaround:
Use TTX to convert ttf file and edit flag before converting back.

@NAKlama NAKlama changed the title 'isFixedPitch' flag not set in font files. 'isFixedPitch' flag not set for Roboto Mono Mar 11, 2016
@davelab6 davelab6 self-assigned this Mar 11, 2016
@davelab6
Copy link
Member

Thanks for reporting this!

@khaledhosny
Copy link
Contributor

Note that isFixedPitch should be set only if all glyphs in the font (including combining marks) have the same width, otherwise rendering might be broken on applications that optimise reading glyph advance widths based on this flag.

@davelab6 davelab6 removed the bug label Jul 25, 2016
@davelab6 davelab6 modified the milestones: Bugs in Font Files, Bugs in Font Files Requiring Rebuild, Bugs in Font Files - Requires Upstream Resolution Aug 10, 2016
@musm
Copy link

musm commented Aug 16, 2016

Pretty sure I just ran into this bug which gives the following : (
Looking forward to a fix for this great mono font. Currently this bug hampers usability on windows.

image

I'm using the TTF files provided here https://fonts.google.com/specimen/Roboto+Mono

@FKlama care to upload the patched ttf files?

@exoton
Copy link

exoton commented Aug 22, 2016

Setting the isFixedPitch flag with ttx does not make this font available in the windows console properties (even after changes to the registry, that are not really required for the TrueType fonts in Windows 10), although it can be now selected in programs like Vim. Something else needs to be changed.

@davelab6
Copy link
Member

davelab6 commented Aug 22, 2016 via email

@exoton
Copy link

exoton commented Aug 22, 2016

Yes, proportion should be 9, not 0:

<panose>
   ...
    <bProportion value="9"/>
    ...
</panose>

@dangerousdan
Copy link

This is silly.
Roboto Mono is listed as a monospaced font, so why don't all glyphs have the same width?
Correct me if I'm wrong, but Isn't that the one thing monospaced fonts should have?

https://codepen.io/anon/pen/qyYoyJ/

@PiotrZierhoffer
Copy link

PiotrZierhoffer commented Sep 21, 2018

I noticed that running fc-list -v :spacing=mono | grep Roboto does not yield any results, neither for Roboto Mono nor for the patched version from @yurakl

I understand this is not a fully monospace font, as I notice the glyphs have different widths. Usually it's 1229, but also 0, 1106, 1227, 1230, 1249, etc etc., up to 2458. I might misunderstand the format (it's my first contact with it), but other monospace fonts I have report either some constant width or 0.

For us, the result is that we cannot align output with spaces when rendering via Pango, but rendering on Windows works fine (both the patched version and the original one).

@mailinglists35
Copy link

hello google, does anyone still work for these fonts?

@davelab6
Copy link
Member

davelab6 commented Sep 24, 2018 via email

@mailinglists35
Copy link

@yurakl given googles' response via @davelab6 which gives zero hopes for an official fix, do you mind sharing your source code patches? I see there are more than quite a few commits to roboto after your build and I'd like to try your patches on the roboto master tree.

@exoton
Copy link

exoton commented Oct 20, 2018

@mailinglists35 I don't have patches. I've used ttx to convert ttf to xml, changed isFixedPitch and bProportion and converted it back to ttf

@s3rb31
Copy link

s3rb31 commented Jan 21, 2019

Why is this not fixed? Cannot be that hard to upload the fixed files.

@davelab6 davelab6 assigned thundernixon and unassigned davelab6 Jan 21, 2019
@davelab6
Copy link
Member

@thundernixon lets queue this up for Q1, you can use TTX to hotfix the binaries

@Kogl1n
Copy link

Kogl1n commented Jan 22, 2019

Thank you! Will you change the version number?

@thundernixon
Copy link
Collaborator

thundernixon commented Jan 22, 2019 via email

@musm
Copy link

musm commented Apr 9, 2019

What's wrong with just using the fonts at #225 (comment) which has the flag correctly set ?

@musm
Copy link

musm commented Apr 9, 2019

Can you also set OS/2 PANOSE Proportion to Monospaced

@speller
Copy link

speller commented Jul 15, 2021

What's wrong with just using the fonts at #225 (comment) which has the flag correctly set ?

The Powerline fonts have some issues with naming (probably) and they're not recognized as a single group of fonts in Ubuntu. I have three groups of fonts in the system instead of a single one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I Font Bug
Projects
None yet
Development

No branches or pull requests