hanna: v1.000 added #1709
Closed
hanna: v1.000 added #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just updated the description file. I copied the text supplied in https://docs.google.com/document/d/11Rc_pitrqWqOFNf4Lnsv7kaTt6fzYSi3V9dqB40aaL8/edit |
|
If it's moving off early access just make it "look like" a normal family (metadata file, etc). For example, ofl/hanna/BM-HANNA.ttf → ofl/hanna/BM-HANNA.ttf.korean shouldn't happen. |
RosaWagner
added
-- Needs confirmation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Woowahan Brothers reported this family was missing to Irin.
I removed it from my Korean pr because this family is already on earlyaccess, #1459 (comment).
Fontbakery report
[23] Family checks
🔥 FAIL: METADATA.pb subsets should be alphabetically ordered.
🍞 PASS: Does DESCRIPTION file contain broken links?
🍞 PASS: Is this a proper HTML snippet?
🍞 PASS: DESCRIPTION.en_us.html must have more than 200 bytes.
🍞 PASS: DESCRIPTION.en_us.html must have less than 1000 bytes.
🍞 PASS: Font designer field in METADATA.pb must not be 'unknown'.
🍞 PASS: Check font has a license.
🍞 PASS: METADATA.pb: Ensure designer simple short name.
🍞 PASS: METADATA.pb: check if fonts field only has unique "full_name" values.
🍞 PASS: METADATA.pb: check if fonts field only contains unique style:weight pairs.
🍞 PASS: METADATA.pb license is "APACHE2", "UFL" or "OFL"?
🍞 PASS: METADATA.pb should contain at least "menu" and "latin" subsets.
🍞 PASS: METADATA.pb: Copyright notice is the same in all fonts?
🍞 PASS: Check that METADATA.pb family values are all the same.
🍞 PASS: METADATA.pb: According Google Fonts standards, families should have a Regular style.
🍞 PASS: METADATA.pb: Regular should be 400.
🍞 PASS: Checking all files are in the same directory.
🍞 PASS: Fonts have equal unicode encodings?
🍞 PASS: Make sure all font files have the same version value.
🍞 PASS: Fonts have consistent PANOSE proportion?
🍞 PASS: Fonts have consistent PANOSE family type?
🍞 PASS: Fonts have consistent underline thickness?
[110] Hanna-Regular.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
💔 ERROR: Glyphs are similiar to Google Fonts version?
💔 ERROR: TTFAutohint x-height increase value is same as in previous release on Google Fonts?
💔 ERROR: Check font has same encoded glyphs as version hosted on fonts.google.com
🔥 FAIL: Font has all expected currency sign characters?
🔥 FAIL: Copyright notice on METADATA.pb matches canonical pattern?
But instead we have got: 'Copright 2018 The Hanna Project Authors'
🔥 FAIL: Checking with Microsoft Font Validator.
/Users/marc/Documents/googlefonts/fonts/ofl/hanna/Hanna-Regular.ttf (file 1 of 1)
Table Test: DSIG
Table Test: GPOS
Table Test: GSUB
Table Test: OS/2
Table Test: cmap
Table Test: cvt
Table Test: fpgm
Table Test: gasp
Table Test: glyf
Progress: Validating glyph with index 0 (out of 2749 glyphs)
Progress: Validating glyph with index 100 (out of 2749 glyphs)
Progress: Validating glyph with index 200 (out of 2749 glyphs)
Progress: Validating glyph with index 300 (out of 2749 glyphs)
Progress: Validating glyph with index 400 (out of 2749 glyphs)
Progress: Validating glyph with index 500 (out of 2749 glyphs)
Progress: Validating glyph with index 600 (out of 2749 glyphs)
Progress: Validating glyph with index 700 (out of 2749 glyphs)
Progress: Validating glyph with index 800 (out of 2749 glyphs)
Progress: Validating glyph with index 900 (out of 2749 glyphs)
Progress: Validating glyph with index 1000 (out of 2749 glyphs)
Progress: Validating glyph with index 1100 (out of 2749 glyphs)
Progress: Validating glyph with index 1200 (out of 2749 glyphs)
Progress: Validating glyph with index 1300 (out of 2749 glyphs)
Progress: Validating glyph with index 1400 (out of 2749 glyphs)
Progress: Validating glyph with index 1500 (out of 2749 glyphs)
Progress: Validating glyph with index 1600 (out of 2749 glyphs)
Progress: Validating glyph with index 1700 (out of 2749 glyphs)
Progress: Validating glyph with index 1800 (out of 2749 glyphs)
Progress: Validating glyph with index 1900 (out of 2749 glyphs)
Progress: Validating glyph with index 2000 (out of 2749 glyphs)
Progress: Validating glyph with index 2100 (out of 2749 glyphs)
Progress: Validating glyph with index 2200 (out of 2749 glyphs)
Progress: Validating glyph with index 2300 (out of 2749 glyphs)
Progress: Validating glyph with index 2400 (out of 2749 glyphs)
Progress: Validating glyph with index 2500 (out of 2749 glyphs)
Progress: Validating glyph with index 2600 (out of 2749 glyphs)
Progress: Validating glyph with index 2700 (out of 2749 glyphs)
Table Test: head
Table Test: hhea
Table Test: hmtx
Table Test: loca
Table Test: maxp
Table Test: name
Table Test: post
Table Test: prep
Begin Raster Test: Black and White
Begin Raster Test: Grayscale
Begin Raster Test: ClearType
Complete: /Users/marc/Documents/googlefonts/fonts/ofl/hanna/Hanna-Regular.ttf.report.xml
Reports are ready!
at OTFontFileVal.OTFontVal.Validate () [0x00482] in <96025b618ca64658ad6b94312cc3f5e3>:0
at OTFontFileVal.OTFontVal.Validate () [0x005f3] in <96025b618ca64658ad6b94312cc3f5e3>:0
at OTFontFileVal.OTFontVal.Validate () [0x0076c] in <96025b618ca64658ad6b94312cc3f5e3>:0
🔥 FAIL: Font contains glyphs for whitespace characters?
The following glyphs do not have the recommended number of contours:
Glyph name: shade Counters detected: 51 Expected: 85
💤 SKIP: METADATA.pb font.style "italic" matches font internals?
💤 SKIP: Check a static ttf can be generated from a variable font.
💤 SKIP: FontForge validation outputs error messages?
💤 SKIP: FontForge checks.
💤 SKIP: Font has **proper** whitespace glyph names?
💤 SKIP: Monospace font has hhea.advanceWidthMax equal to each glyph's advanceWidth?
💤 SKIP: Whitespace and non-breaking space have the same width?
💤 SKIP: Is there kerning info for non-ligated sequences?
💤 SKIP: Is there a caret position declared for every ligature?
💤 SKIP: The variable font 'wght' (Weight) axis coordinate must be 400 on the 'Regular' instance.
💤 SKIP: The variable font 'wdth' (Width) axis coordinate must be 100 on the 'Regular' instance.
💤 SKIP: The variable font 'slnt' (Slant) axis coordinate must be zero on the 'Regular' instance.
💤 SKIP: The variable font 'ital' (Italic) axis coordinate must be zero on the 'Regular' instance.
💤 SKIP: The variable font 'opsz' (Optical Size) axis coordinate should be between 9 and 13 on the 'Regular' instance.
💤 SKIP: The variable font 'wght' (Weight) axis coordinate must be 700 on the 'Bold' instance.
ℹ️ INFO: Show hinting filesize impact.
ℹ️ INFO: Font has old ttfautohint applied?
ℹ️ INFO: EPAR table present in font?
ℹ️ INFO: Familyname must be unique according to namecheck.fontdata.com
Please visit http://namecheck.fontdata.com/?q=Hanna for more info.
ℹ️ INFO: Check for font-v versioning
The version string must ideally include a git commit hash and either a 'dev' or a 'release' suffix such as in the example below:
"Version 1.3; git-0d08353-release"
ℹ️ INFO: Font contains all required tables?
🍞 PASS: Checking file is named canonically.
🍞 PASS: Fonts have equal numbers of glyphs?
🍞 PASS: Fonts have equal glyph names?
🍞 PASS: Checking OS/2 fsType.
🍞 PASS: Substitute copyright, registered and trademark symbols in name table entries.
🍞 PASS: Checking OS/2 usWeightClass.
🍞 PASS: Check copyright namerecords match license file.
🍞 PASS: "License URL matches License text on name table?
🍞 PASS: Description strings in the name table must not exceed 200 characters.
🍞 PASS: Version format is correct in 'name' table?
🍞 PASS: Is 'gasp' table set to optimize rendering?
🍞 PASS: Make sure family name does not begin with a digit.
🍞 PASS: Are there non-ASCII characters in ASCII-only NAME table entries?
🍞 PASS: Checks METADATA.pb font.name field matches family name declared on the name table.
🍞 PASS: Checks METADATA.pb font.post_script_name matches postscript name declared on the name table.
🍞 PASS: METADATA.pb font.full_name value matches fullname declared on the name table?
🍞 PASS: METADATA.pb font.name value should be same as the family name declared on the name table.
🍞 PASS: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?
🍞 PASS: METADATA.pb font.filename and font.post_script_name fields have equivalent values?
🍞 PASS: METADATA.pb font.name field contains font name in right format?
🍞 PASS: METADATA.pb font.full_name field contains font name in right format?
🍞 PASS: METADATA.pb font.filename field contains font name in right format?
🍞 PASS: METADATA.pb font.post_script_name field contains font name in right format?
🍞 PASS: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
🍞 PASS: METADATA.pb: Copyright notice shouldn't exceed 500 chars.
🍞 PASS: METADATA.pb: Filename is set canonically?
🍞 PASS: METADATA.pb font.style "normal" matches font internals?
🍞 PASS: METADATA.pb font.name and font.full_name fields match the values declared on the name table?
🍞 PASS: METADATA.pb: Check if fontname is not camel cased.
🍞 PASS: METADATA.pb: Check font name is the same as family name.
🍞 PASS: METADATA.pb: Check that font weight has a canonical value.
🍞 PASS: Checking OS/2 usWeightClass matches weight specified at METADATA.pb.
🍞 PASS: METADATA.pb weight matches postScriptName.
🍞 PASS: METADATA.pb: Font styles are named canonically?
🍞 PASS: Is font em size (ideally) equal to 1000?
🍞 PASS: Checking OS/2 fsSelection value.
🍞 PASS: Checking post.italicAngle value.
🍞 PASS: Checking head.macStyle value.
🍞 PASS: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
🍞 PASS: Font has all mandatory 'name' table entries ?
🍞 PASS: Check name table: FONT_FAMILY_NAME entries.
🍞 PASS: Check name table: FONT_SUBFAMILY_NAME entries.
🍞 PASS: Check name table: FULL_FONT_NAME entries.
🍞 PASS: Check name table: POSTSCRIPT_NAME entries.
🍞 PASS: Check name table: TYPOGRAPHIC_FAMILY_NAME entries.
🍞 PASS: Check name table: TYPOGRAPHIC_SUBFAMILY_NAME entries.
🍞 PASS: Length of copyright notice must not exceed 500 characters.
🍞 PASS: Checking OS/2 usWinAscent & usWinDescent.
🍞 PASS: Checking OS/2 Metrics match hhea Metrics.
🍞 PASS: Font enables smart dropout control in "prep" table instructions?
🍞 PASS: Checking with ftxvalidator.
🍞 PASS: Checking with ots-sanitize.
🍞 PASS: Whitespace glyphs have ink?
🍞 PASS: Are there unwanted tables?
🍞 PASS: Glyph names are all valid?
🍞 PASS: Font contains unique glyph names?
🍞 PASS: Checking with fontTools.ttx
🍞 PASS: Check glyphs have unique unicode codepoints.
🍞 PASS: Check all glyphs have codepoints assigned.
🍞 PASS: Checking unitsPerEm value is reasonable.
🍞 PASS: Checking font version fields (head and name table).
🍞 PASS: Check if OS/2 xAvgCharWidth is correct.
🍞 PASS: Font has correct post table version (2 for TTF, 3 for OTF)?
🍞 PASS: Description strings in the name table must not contain copyright info.
🍞 PASS: Checking correctness of monospaced metadata.
🍞 PASS: Name table entries should not contain line-breaks.
🍞 PASS: Does full font name begin with the font family name?
🍞 PASS: Font follows the family naming recommendations?
🍞 PASS: Name table strings must not contain the string 'Reserved Font Name'.
🍞 PASS: Combined length of family and style must not exceed 20 characters.
🍞 PASS: MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🍞 PASS: Does the font have a DSIG table?
🍞 PASS: Is there a "kern" table declared in the font?
🍞 PASS: Is there any unused data at the end of the glyf table?
🍞 PASS: Check for points out of bounds.
🍞 PASS: Does the number of glyphs in the loca table match the maxp table?
Summary
Win7 IE9
Win7 IE9
QA Summary