Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roboto Slab: v2.000 VF and statics added #1791

Closed
wants to merge 9 commits into from
Closed

Roboto Slab: v2.000 VF and statics added #1791

wants to merge 9 commits into from

Conversation

mjlagattuta
Copy link
Contributor

@mjlagattuta mjlagattuta commented Dec 14, 2018 •
edited
Loading

Upstream repo: https://github.com/googlefonts/robotoslab

To Do

  • Fix/confirm VF METADATA.pb naming
  • Correct ttfautohint-vf results via control file

Questions

  • ots sanitize on VF is failing, is that expected?

Fontbakery Reports

Taken from upstream repo @ commit: ac178bb

Fontbakery report statics Fontbakery version: 0.6.5
[6] RobotoSlab-Black.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Combined length of family and style must not exceed 20 characters.
  • com.google.fonts/check/163
  • ⚠️ WARN The combined length of family and style exceeds 20 chars in the following 'WINDOWS' entries: FONT_FAMILY_NAME = 'Roboto Slab Black' / SUBFAMILY_NAME = 'Regular'
⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]

⚠️ WARN: Check for points out of bounds.
  • com.google.fonts/check/075
  • ⚠️ WARN The following glyphs have coordinates which are out of bounds:
    [('endash', 167.70000000000002, 572.0), ('endash', 167.70000000000002, 845.0), ('greaterequal', 88.0, 1205.3000000000002), ('lessequal', 918.0, 1184.1)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

[4] RobotoSlab-Bold.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]


[6] RobotoSlab-Light.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Combined length of family and style must not exceed 20 characters.
  • com.google.fonts/check/163
  • ⚠️ WARN The combined length of family and style exceeds 20 chars in the following 'WINDOWS' entries: FONT_FAMILY_NAME = 'Roboto Slab Light' / SUBFAMILY_NAME = 'Regular'
⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]

⚠️ WARN: Check for points out of bounds.
  • com.google.fonts/check/075
  • ⚠️ WARN The following glyphs have coordinates which are out of bounds:
    [('greaterequal', 146.0, 1013.3000000000001), ('lessequal', 987.0, 1010.5)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

[6] RobotoSlab-Medium.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Combined length of family and style must not exceed 20 characters.
  • com.google.fonts/check/163
  • ⚠️ WARN The combined length of family and style exceeds 20 chars in the following 'WINDOWS' entries: FONT_FAMILY_NAME = 'Roboto Slab Medium' / SUBFAMILY_NAME = 'Regular'
⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]

⚠️ WARN: Check for points out of bounds.
  • com.google.fonts/check/075
  • ⚠️ WARN The following glyphs have coordinates which are out of bounds:
    [('lessequal', 964.0, 1116.1)]
    This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message

[4] RobotoSlab-Regular.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]


[6] RobotoSlab-Thin.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
⚠️ WARN: Checking OS/2 usWeightClass.
  • com.google.fonts/check/020
  • ⚠️ WARN {}:{} is OK on TTFs, but OTF files with those values will cause bluring on Windows. GlyphsApp users must set a Instance Custom Parameter for the Thin and ExtraLight styles to 250 and 275, so that if OTFs are exported then it will not blur on Windows.
⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Combined length of family and style must not exceed 20 characters.
  • com.google.fonts/check/163
  • ⚠️ WARN The combined length of family and style exceeds 20 chars in the following 'WINDOWS' entries: FONT_FAMILY_NAME = 'Roboto Slab Thin' / SUBFAMILY_NAME = 'Regular'
⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]


Summary

💔 ERROR 🔥 FAIL ⚠️ WARN 💤 SKIP ℹ️ INFO 🍞 PASS
6 0 26 268 37 390
1% 0% 4% 37% 5% 54%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
Fontbakery report VF Fontbakery version: 0.6.5
[25] Family checks
ℹ️ INFO: Do we have the latest version of FontBakery installed?
🍞 PASS: Check font has a license.
  • com.google.fonts/check/028
  • 🍞 PASS Found license at '/Users/lags/Google Drive/Work/GoogleFonts/VF-Upgrades/Roboto-Slab-Project/robotoslab/LICENSE.txt'
🍞 PASS: Checking all files are in the same directory.
🍞 PASS: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
🍞 PASS: Fonts have equal unicode encodings?
🍞 PASS: Make sure all font files have the same version value.
🍞 PASS: Fonts have consistent PANOSE proportion?
🍞 PASS: Fonts have consistent PANOSE family type?
🍞 PASS: Fonts have consistent underline thickness?
💤 SKIP: Does DESCRIPTION file contain broken links?
💤 SKIP: Is this a proper HTML snippet?
💤 SKIP: DESCRIPTION.en_us.html must have more than 200 bytes.
💤 SKIP: DESCRIPTION.en_us.html must have less than 1000 bytes.
💤 SKIP: Check METADATA.pb parse correctly.
💤 SKIP: Font designer field in METADATA.pb must not be 'unknown'.
💤 SKIP: METADATA.pb: Fontfamily is listed on Google Fonts API?
💤 SKIP: METADATA.pb: check if fonts field only has unique "full_name" values.
💤 SKIP: METADATA.pb: check if fonts field only contains unique style:weight pairs.
💤 SKIP: METADATA.pb license is "APACHE2", "UFL" or "OFL"?
💤 SKIP: METADATA.pb should contain at least "menu" and "latin" subsets.
💤 SKIP: METADATA.pb subsets should be alphabetically ordered.
💤 SKIP: METADATA.pb: Copyright notice is the same in all fonts?
💤 SKIP: Check that METADATA.pb family values are all the same.
💤 SKIP: METADATA.pb: According Google Fonts standards, families should have a Regular style.
💤 SKIP: METADATA.pb: Regular should be 400.

[117] RobotoSlab-VF.ttf
💔 ERROR: Version number has increased since previous release on Google Fonts?
  • com.google.fonts/check/117
  • 💔 ERROR The condition FontBakeryCondition:github_gfonts_ttFont had an error: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:841)>
🔥 FAIL: Checking with ots-sanitize.

ERROR: GDEF: bad caret value format: 3
ERROR: GDEF: Invalid ligature caret list
ERROR: GDEF: Failed to parse table
Failed to sanitize file!

⚠️ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/116
  • ⚠️ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will liely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
⚠️ WARN: Check if each glyph has the recommended amount of contours.
  • com.google.fonts/check/153
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

Glyph name: K Contours detected: 3 Expected: 1 or 2
Glyph name: R Contours detected: 3 Expected: 1 or 2
Glyph name: k Contours detected: 3 Expected: 1 or 2
Glyph name: Eth Contours detected: 3 Expected: 2
Glyph name: aogonek Contours detected: 3 Expected: 2
Glyph name: Dcroat Contours detected: 3 Expected: 2
Glyph name: dcroat Contours detected: 3 Expected: 2
Glyph name: eogonek Contours detected: 3 Expected: 2
Glyph name: hbar Contours detected: 2 Expected: 1
Glyph name: uni0136 Contours detected: 4 Expected: 2 or 3
Glyph name: uni0137 Contours detected: 4 Expected: 2 or 3
Glyph name: kgreenlandic Contours detected: 3 Expected: 1 or 2
Glyph name: Lslash Contours detected: 2 Expected: 1
Glyph name: lslash Contours detected: 2 Expected: 1
Glyph name: Racute Contours detected: 4 Expected: 3
Glyph name: uni0156 Contours detected: 4 Expected: 3
Glyph name: Rcaron Contours detected: 4 Expected: 3
Glyph name: Tbar Contours detected: 2 Expected: 1
Glyph name: tbar Contours detected: 2 Expected: 1
Glyph name: Uogonek Contours detected: 2 Expected: 1
Glyph name: uogonek Contours detected: 2 Expected: 1
Glyph name: ohorn Contours detected: 3 Expected: 2
Glyph name: Uhorn Contours detected: 2 Expected: 1
Glyph name: uhorn Contours detected: 2 Expected: 1
Glyph name: Kappa Contours detected: 3 Expected: 1
Glyph name: kappa Contours detected: 3 Expected: 1
Glyph name: uni045B Contours detected: 2 Expected: 1
Glyph name: uni0462 Contours detected: 3 Expected: 2
Glyph name: uni046C Contours detected: 3 Expected: 2
Glyph name: uni046D Contours detected: 3 Expected: 2
Glyph name: uni047A Contours detected: 4 Expected: 2
Glyph name: uni047B Contours detected: 4 Expected: 2
Glyph name: uni048C Contours detected: 3 Expected: 2
Glyph name: uni048E Contours detected: 3 Expected: 1 or 2
Glyph name: uni048F Contours detected: 3 Expected: 2
Glyph name: uni0492 Contours detected: 2 Expected: 1
Glyph name: uni0493 Contours detected: 2 Expected: 1
Glyph name: uni049C Contours detected: 2 Expected: 1
Glyph name: uni049D Contours detected: 2 Expected: 1
Glyph name: uni049E Contours detected: 2 Expected: 1
Glyph name: Ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: ustraitstrokecy Contours detected: 2 Expected: 1
Glyph name: uni04B8 Contours detected: 2 Expected: 1
Glyph name: uni04B9 Contours detected: 2 Expected: 1
Glyph name: uni04FE Contours detected: 2 Expected: 1
Glyph name: uni04FF Contours detected: 2 Expected: 1
Glyph name: uni0506 Contours detected: 2 Expected: 1
Glyph name: uni0507 Contours detected: 2 Expected: 1
Glyph name: uni1E9E Contours detected: 2 Expected: 1
Glyph name: uni1EDB Contours detected: 4 Expected: 3
Glyph name: uni1EDD Contours detected: 4 Expected: 3
Glyph name: uni1EDF Contours detected: 4 Expected: 3
Glyph name: uni1EE1 Contours detected: 4 Expected: 3
Glyph name: uni1EE3 Contours detected: 4 Expected: 3
Glyph name: uni1EE8 Contours detected: 3 Expected: 2
Glyph name: uni1EE9 Contours detected: 3 Expected: 2
Glyph name: uni1EEA Contours detected: 3 Expected: 2
Glyph name: uni1EEB Contours detected: 3 Expected: 2
Glyph name: uni1EEC Contours detected: 3 Expected: 2
Glyph name: uni1EED Contours detected: 3 Expected: 2
Glyph name: uni1EEE Contours detected: 3 Expected: 2
Glyph name: uni1EEF Contours detected: 3 Expected: 2
Glyph name: uni1EF0 Contours detected: 3 Expected: 2
Glyph name: uni1EF1 Contours detected: 3 Expected: 2

⚠️ WARN: Is there kerning info for non-ligated sequences?

  • com.google.fonts/check/065

  • ⚠️ WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i
    • i + l

    [code: lacks-kern-info]

💤 SKIP: Checking OS/2 usWeightClass.
💤 SKIP: Font has ttfautohint params?
💤 SKIP: Checks METADATA.pb font.name field matches family name declared on the name table.
💤 SKIP: Checks METADATA.pb font.post_script_name matches postscript name declared on the name table.
💤 SKIP: METADATA.pb font.full_name value matches fullname declared on the name table?
💤 SKIP: METADATA.pb font.name value should be same as the family name declared on the name table.
💤 SKIP: METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?
💤 SKIP: METADATA.pb font.filename and font.post_script_name fields have equivalent values?
💤 SKIP: METADATA.pb font.name field contains font name in right format?
💤 SKIP: METADATA.pb font.full_name field contains font name in right format?
💤 SKIP: METADATA.pb font.filename field contains font name in right format?
💤 SKIP: METADATA.pb font.post_script_name field contains font name in right format?
💤 SKIP: Copyright notices match canonical pattern?
💤 SKIP: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
💤 SKIP: METADATA.pb: Copyright notice shouldn't exceed 500 chars.
💤 SKIP: METADATA.pb: Filename is set canonically?
💤 SKIP: METADATA.pb font.style "italic" matches font internals?
💤 SKIP: METADATA.pb font.style "normal" matches font internals?
💤 SKIP: METADATA.pb font.name and font.full_name fields match the values declared on the name table?
💤 SKIP: METADATA.pb: Check if fontname is not camel cased.
💤 SKIP: METADATA.pb: Check font name is the same as family name.
💤 SKIP: METADATA.pb: Check that font weight has a canonical value.
💤 SKIP: Checking OS/2 usWeightClass matches weight specified at METADATA.pb.
💤 SKIP: METADATA.pb weight matches postScriptName.
💤 SKIP: METADATA.pb: Font styles are named canonically?
💤 SKIP: Glyphs are similiar to Google Fonts version?
💤 SKIP: TTFAutohint x-height increase value is same as in previous release on Google Fonts?
💤 SKIP: Checking OS/2 fsSelection value.
💤 SKIP: Checking post.italicAngle value.
💤 SKIP: Checking head.macStyle value.
💤 SKIP: Check font has same encoded glyphs as version hosted on fonts.google.com
💤 SKIP: Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?
💤 SKIP: Font has all mandatory 'name' table entries ?
💤 SKIP: Check name table: FONT_FAMILY_NAME entries.
💤 SKIP: Check name table: FONT_SUBFAMILY_NAME entries.
💤 SKIP: Check name table: FULL_FONT_NAME entries.
💤 SKIP: Check name table: POSTSCRIPT_NAME entries.
💤 SKIP: Check name table: TYPOGRAPHIC_FAMILY_NAME entries.
💤 SKIP: Check name table: TYPOGRAPHIC_SUBFAMILY_NAME entries.
💤 SKIP: FontForge validation outputs error messages?
💤 SKIP: FontForge checks.
💤 SKIP: CFF table FontName must match name table ID 6 (PostScript name).
💤 SKIP: Monospace font has hhea.advanceWidthMax equal to each glyph's advanceWidth?
💤 SKIP: The variable font 'wdth' (Width) axis coordinate must be 100 on the 'Regular' instance.
💤 SKIP: The variable font 'slnt' (Slant) axis coordinate must be zero on the 'Regular' instance.
💤 SKIP: The variable font 'ital' (Italic) axis coordinate must be zero on the 'Regular' instance.
💤 SKIP: The variable font 'opsz' (Optical Size) axis coordinate should be between 9 and 13 on the 'Regular' instance.
ℹ️ INFO: Show hinting filesize impact.
RobotoSlab-VF.ttf
Dehinted Size 245.6kb
Hinted Size 245.0kb
Increase -588 bytes
Change -0.2 %
ℹ️ INFO: Font has old ttfautohint applied?
  • com.google.fonts/check/056
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']
ℹ️ INFO: EPAR table present in font?
ℹ️ INFO: Is 'gasp' table set to optimize rendering?

PPM <= 65535:
flag = 0x0F
- Use gridfitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®

  • 🍞 PASS 'gasp' table is correctly set, with one gaspRange:value of 0xFFFF:0x0F.
ℹ️ INFO: Check for font-v versioning
  • com.google.fonts/check/166
  • ℹ️ INFO Version string is: "Version 2.000"
    The version string must ideally include a git commit hash and either a 'dev' or a 'release' suffix such as in the example below:
    "Version 1.3; git-0d08353-release"
ℹ️ INFO: Font contains all required tables?
  • com.google.fonts/check/052
  • ℹ️ INFO This font contains the following optional tables [prep, DSIG, gasp, loca, GSUB, GPOS]
  • 🍞 PASS Font contains all required tables.
ℹ️ INFO: Check if OS/2 xAvgCharWidth is correct.
🍞 PASS: Checking file is named canonically.
🍞 PASS: Fonts have equal numbers of glyphs?
🍞 PASS: Fonts have equal glyph names?
🍞 PASS: Checking OS/2 fsType.
🍞 PASS: Checking OS/2 achVendID.
🍞 PASS: Substitute copyright, registered and trademark symbols in name table entries.
  • com.google.fonts/check/019
  • 🍞 PASS No need to substitute copyright, registered and trademark symbols in name table entries of this font.
🍞 PASS: Check copyright namerecords match license file.
🍞 PASS: "License URL matches License text on name table?
🍞 PASS: Description strings in the name table must not exceed 200 characters.
🍞 PASS: Version format is correct in 'name' table?
🍞 PASS: Make sure family name does not begin with a digit.
🍞 PASS: Font has all expected currency sign characters?
🍞 PASS: Are there non-ASCII characters in ASCII-only NAME table entries?
🍞 PASS: Length of copyright notice must not exceed 500 characters.
🍞 PASS: Familyname must be unique according to namecheck.fontdata.com
🍞 PASS: Check a static ttf can be generated from a variable font.
🍞 PASS: Check that variable fonts have an HVAR table.
🍞 PASS: Checking OS/2 usWinAscent & usWinDescent.
🍞 PASS: Checking OS/2 Metrics match hhea Metrics.
🍞 PASS: Font enables smart dropout control in "prep" table instructions?
🍞 PASS: There must not be VTT Talk sources in the font.
🍞 PASS: Are there unwanted Apple tables?
🍞 PASS: All name entries referenced by fvar instances exist on the name table?
🍞 PASS: A variable font must have named instances.
🍞 PASS: Variable font weight coordinates must be multiples of 100.
🍞 PASS: Checking with ftxvalidator.
🍞 PASS: Font contains .notdef as first glyph?
  • com.google.fonts/check/046
  • 🍞 PASS Font contains the .notdef glyph as the first glyph, it does not have a Unicode value assigned and contains a drawing.
🍞 PASS: Font contains glyphs for whitespace characters?
🍞 PASS: Font has **proper** whitespace glyph names?
🍞 PASS: Whitespace glyphs have ink?
🍞 PASS: Are there unwanted tables?
🍞 PASS: Glyph names are all valid?
🍞 PASS: Font contains unique glyph names?
🍞 PASS: Checking with fontTools.ttx
🍞 PASS: Check glyphs have unique unicode codepoints.
🍞 PASS: Check all glyphs have codepoints assigned.
🍞 PASS: Checking unitsPerEm value is reasonable.
🍞 PASS: Checking font version fields (head and name table).
🍞 PASS: Font has correct post table version (2 for TTF, 3 for OTF)?
🍞 PASS: Description strings in the name table must not contain copyright info.
🍞 PASS: Checking correctness of monospaced metadata.
🍞 PASS: Name table entries should not contain line-breaks.
🍞 PASS: Does full font name begin with the font family name?
🍞 PASS: Font follows the family naming recommendations?
🍞 PASS: Name table strings must not contain the string 'Reserved Font Name'.
🍞 PASS: Combined length of family and style must not exceed 20 characters.
🍞 PASS: Checking Vertical Metric Linegaps.
🍞 PASS: MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
🍞 PASS: Does the font have a DSIG table?
🍞 PASS: Whitespace and non-breaking space have the same width?
🍞 PASS: Does GPOS table have kerning information?
🍞 PASS: Are there caret positions declared for every ligature?
🍞 PASS: Is there a "kern" table declared in the font?
🍞 PASS: Is there any unused data at the end of the glyf table?
🍞 PASS: Check for points out of bounds.
🍞 PASS: The variable font 'wght' (Weight) axis coordinate must be 400 on the 'Regular' instance.
🍞 PASS: The variable font 'wght' (Weight) axis coordinate must be 700 on the 'Bold' instance.
🍞 PASS: Does the number of glyphs in the loca table match the maxp table?

Summary

💔 ERROR 🔥 FAIL ⚠️ WARN 💤 SKIP ℹ️ INFO 🍞 PASS
1 1 3 63 8 66
1% 1% 2% 44% 6% 46%

@mjlagattuta mjlagattuta changed the title Robotoslab Roboto Slab: v2.000 VF and statics added Dec 14, 2018
@mjlagattuta mjlagattuta added the III VF Replacement Replace an existing family of static fonts with variable fonts label Dec 14, 2018
@mjlagattuta mjlagattuta changed the title Roboto Slab: v2.000 VF and statics added Roboto Slab: v2.000 VF and statics added — WIP Dec 14, 2018
@mjlagattuta mjlagattuta changed the title Roboto Slab: v2.000 VF and statics added — WIP Roboto Slab: v2.000 VF and statics added Feb 12, 2019
@mjlagattuta
Copy link
Contributor Author

I've removed the WIP label as this is ready for review. A note that there may be minor hinting issues as documented in the upstream repo, but this is after getting the best results possible using a control file.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 23, 2019

Fontbakery report

Fontbakery version: 0.7.14

[1] Family checks
🔥 FAIL: Does font file include unacceptable control character glyphs?
  • com.google.fonts/check/family/control_chars
  • 🔥 FAIL The following unacceptable control characters were identified:
    /var/folders/y0/gs7dshh54gng8n1zgzr53nbw0000gn/T/tmpgpt862cj/RobotoSlab[wght].ttf: uni0002, uni0009
    [code: unacceptable]

[5] RobotoSlab[wght].ttf
🔥 FAIL: Check glyph coverage.
🔥 FAIL: Font has old ttfautohint applied?
🔥 FAIL: PPEM must be an integer on hinted fonts.

This can be accomplished by using the 'gftools fix-hinting' command.

create virtualenvpython3 -m venv venv

activate virtualenvsource venv/bin/activate

install gftoolspip install git+https://www.github.com/googlefonts/tools [code: bad-flags]

⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
  • com.google.fonts/check/unitsperem_strict
  • ⚠ WARN Even though unitsPerEm (2048) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations. [code: legacy-value]
⚠ WARN: Is there kerning info for non-ligated sequences?

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 2 74 6 75 0
0% 2% 1% 46% 4% 47% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

Diff images: robotoslab_qa.zip

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 24, 2019

We need to improve the hinting. The accent positioning doesn't look good.

Desktop_Windows_10_chrome_69 0_

Win10 Chrome 69

I'll start building the newer TTFA.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 11, 2019

closing #2251 is newer.

@m4rc1e m4rc1e closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
III VF Replacement Replace an existing family of static fonts with variable fonts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjlagattuta @googlebot @m4rc1e @davelab6