Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roboto to v3 ("Roboto Classic") #2414

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Update Roboto to v3 ("Roboto Classic") #2414

merged 1 commit into from
Apr 13, 2020

Conversation

davelab6
Copy link
Member

@davelab6 davelab6 commented Apr 8, 2020 •
edited
Loading

  • Add VFs with weight and width axes
  • Upgrade license from Apache to OFL
  • Remove legacy fonts
  • Add old static files from v2.136 roboto-hinted.zip release as the VF files are not subset as previous web releases were

@davelab6 davelab6 requested a review from m4rc1e April 8, 2020 17:35
@davelab6 davelab6 force-pushed the davelab6-roboto-v3 branch 3 times, most recently from 79b5e62 to b983641 Compare April 8, 2020 22:32
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google google deleted a comment from googlebot Apr 8, 2020
@davelab6
Copy link
Member Author

davelab6 commented Apr 9, 2020

Add old static files from v2.136 roboto-hinted.zip release as the VF files are not subset as previous web releases were

@rsheeter note that these are not "web subset" per your internal request to do so, but this will inflate the size of the latin-ext and cyrillic-ext subsets generated in the API

@davelab6
Copy link
Member Author

@m4rc1e OK, @rsheeter confirmed that he wants to proceeed ASAP so I'll add the web-subset statics here and merge

@davelab6
Update Roboto to v3 ("Roboto Classic")
ee5c006 
- Add VFs with weight and width axes
- Upgrade license from Apache to OFL
- Move legacy fonts from apache/roboto*/*ttf to ofl/roboto/static/*ttf
@davelab6 davelab6 merged commit 113bac0 into master Apr 13, 2020
@davelab6 davelab6 deleted the davelab6-roboto-v3 branch April 13, 2020 21:27
@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 14, 2020

This PR has the following issues:

  • Version number is not v3.000
  • Apache license info is still present in fonts
  • No viz diffs/sign off have occurred.

@davelab6 would you like the above done and pushed in a new pr?

@davelab6
Copy link
Member Author

yes please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e Awaiting requested review from m4rc1e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davelab6 @googlebot @m4rc1e