Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Syriac Eastern: Version 3.001 added #5740

Merged
merged 2 commits into from Jun 22, 2023

Conversation

simoncozens
Copy link
Collaborator

4cf61af: [gftools-packager] Noto Sans Syriac Eastern: Version 3.000 added

@simoncozens
Copy link
Collaborator Author

Updated

Noto Sans Syriac Eastern: Version 3.001 added


180e58f: [gftools-packager] Noto Sans Syriac Eastern: Version 3.001 added

@simoncozens simoncozens force-pushed the gftools_packager_ofl_notosanssyriaceastern branch from 180e58f to 9229fac Compare January 11, 2023 10:47
@simoncozens simoncozens changed the title Noto Sans Syriac Eastern: Version 3.000 added Noto Sans Syriac Eastern: Version 3.001 added Jan 11, 2023
@simoncozens simoncozens added this to the 2023 Q2 milestone Feb 28, 2023
@RosaWagner RosaWagner added -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) and removed - Ready for Review labels Mar 29, 2023
@simoncozens simoncozens self-assigned this Jun 22, 2023
@simoncozens simoncozens removed their assignment Jun 22, 2023
@simoncozens simoncozens removed the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Jun 22, 2023
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[16] NotoSansSyriacEastern[wght].ttf
🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̠ ĭ̠ i̠̇ i̠̊ i̠̋ ǐ̠ i̠̒ ị̃ ị̆ ị̇ ị̊ ị̋ ị̌ ị̒ ĩ̤ [code: soft-dotted]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, tifinagh, math

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, syriac [code: unreachable-subsetting]

WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
    FONT_FAMILY_NAME = 'Noto Sans Syriac Eastern' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • guillemotleft.1

    • guillemotright.1

    • tildecomb

    • uni0304.1

    • uni0307.1

    • uni0308.1

    • uni030A.1

    • uni0710.medi.2N
      [code: unreachable-glyphs]

WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 2 start point differs in glyph 'uni0723.fina' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f5b97753e20> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f5b97750be0> [code: interpolation-issues]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 572 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 573:
plus, equal, minus
[code: width-outliers]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosanssyriaceastern/NotoSansSyriacEastern[wght].ttf
Dehinted Size 142.9kb
Hinted Size 142.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.001'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.001"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosanssyriaceastern [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 8 47 8 182 0
0% 0% 3% 19% 3% 74% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 7a51521 into main Jun 22, 2023
6 of 7 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_notosanssyriaceastern branch June 22, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

None yet

2 participants