-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agbalumo: Version 1.000; ttfautohint (v1.8.4) added #6830
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Updated Agbalumo: Version 1.000; ttfautohint (v1.8.4) added0215c94: [gftools-packager] Agbalumo: Version 1.000; ttfautohint (v1.8.4) added
|
8a7215a
to
0215c94
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Updated agbalumo: Version 1.000; ttfautohint (v1.8.4) addedc8dfc0c: [gftools-packager] agbalumo: Version 1.000; ttfautohint (v1.8.4) added
|
0215c94
to
c8dfc0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Updated Agbalumo: Version 1.000; ttfautohint (v1.8.4) addedb49e64f: [gftools-packager] Agbalumo: Version 1.000; ttfautohint (v1.8.4) added
|
c8dfc0c
to
b49e64f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This project used to be called Danfo, but the name was recently changed to Agbalumo. Here is the add font issue: #6515 |
If the "development" panel doesn't work to link the issue to can add the issue number with a closing word to achieve the linking :) |
I confirm this is intended as a single style display face, and if it is expanded in future with a range of weights, the design itself would be modified to be more suitable for text, and so would be a separate family "Agbalumo Pro" or so. |
This was resolved in various chats today, we are going to go ahead with onboarding this as just "Agbalumo" without "One" appended. The docs might need to be updated to make it clear this requirement isn't absolutely necessary and exceptions can be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved all the issues brought up by Rosalie and Dave, making a new pull request soon for a second review.
* Agbalumo Version 1.000; ttfautohint (v1.8.4) taken from the upstream repo https://github.com/SorkinType/Agbalumo.git at commit SorkinType/Agbalumo@c6c381d.
Updated Agbalumo: Version 1.000; ttfautohint (v1.8.4) added6a9a2d7: [gftools-packager] Agbalumo: Version 1.000; ttfautohint (v1.8.4) added
|
b49e64f
to
6a9a2d7
Compare
FontBakery reportfontbakery version: 0.9.2 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[19] Agbalumo-Regular.ttf⚠ WARN: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 554: Width = 515: Width = 521: Width = 565: Width = 579: Width = 541: Width = 548: Width = 546: Width = 502: Width = 506: ⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments] ⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
Your font fully covers the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers), Ebira (Latn, 2,200,000 speakers), Nateni (Latn, 100,000 speakers), Aghem (Latn, 38,843 speakers), Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers), Ma’di (Latn, 584,000 speakers), Lugbara (Latn, 2,200,000 speakers), Basaa (Latn, 332,940 speakers). Your font does not cover the following languages that require the soft-dotted feature: Dan (Latn, 1,099,244 speakers), Ejagham (Latn, 120,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers). [code: soft-dotted] ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
@RosaWagner About the designer credits, Raphael should be Principal Design, but Eben should be included as a secondary designer. I included both Sorkin Type and Eben Sorkin in the credits because the font is hosted on the Sorkin Type GitHub, lists Sorkin Type as the manufacturer, and other similar fonts already on Google fonts do the same thing, I looked at Calistoga as an example: https://fonts.google.com/specimen/Calistoga/about ColumnType is a label Raphael wants to use to release more fonts under. The ColumnType website is not live, and the only online presence I know of is an Instagram page with a few posts: https://www.instagram.com/columntype |
I see only one small issue so it won't block the merging, but maybe @eliheuer you can raise an issue upstream so it can be fixed in a next update. There is an inconsistency between
A good practice would be to achieve that through with sidebearing of |
Thanks! I filled an issue upstream. Eben and the designer are planning on a v 1.100 update this year, so I will try to make sure this is fixed. |
8a7215a: [gftools-packager] agbalumo: Version 1.000; ttfautohint (v1.8.4) added
Resolves #6515