Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agbalumo: Version 1.000; ttfautohint (v1.8.4) added #6830

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eliheuer
Copy link
Collaborator

@eliheuer eliheuer commented Oct 4, 2023

8a7215a: [gftools-packager] agbalumo: Version 1.000; ttfautohint (v1.8.4) added

Resolves #6515

@github-actions

This comment was marked as outdated.

@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 4, 2023

Updated

Agbalumo: Version 1.000; ttfautohint (v1.8.4) added


0215c94: [gftools-packager] Agbalumo: Version 1.000; ttfautohint (v1.8.4) added

@eliheuer eliheuer force-pushed the gftools_packager_ofl_agbalumo branch from 8a7215a to 0215c94 Compare October 4, 2023 11:31
@github-actions

This comment was marked as outdated.

@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 4, 2023

Updated

agbalumo: Version 1.000; ttfautohint (v1.8.4) added


c8dfc0c: [gftools-packager] agbalumo: Version 1.000; ttfautohint (v1.8.4) added

@eliheuer eliheuer force-pushed the gftools_packager_ofl_agbalumo branch from 0215c94 to c8dfc0c Compare October 4, 2023 16:17
@github-actions

This comment was marked as outdated.

@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 4, 2023

Updated

Agbalumo: Version 1.000; ttfautohint (v1.8.4) added


b49e64f: [gftools-packager] Agbalumo: Version 1.000; ttfautohint (v1.8.4) added

@eliheuer eliheuer force-pushed the gftools_packager_ofl_agbalumo branch from c8dfc0c to b49e64f Compare October 4, 2023 16:33
@github-actions

This comment was marked as outdated.

@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 4, 2023

This project used to be called Danfo, but the name was recently changed to Agbalumo.

Here is the add font issue: #6515

@RosaWagner
Copy link
Contributor

RosaWagner commented Oct 5, 2023

Since the font is quite thick, we need to decide if it should have "One" appended to the name to be able to onboard other weights later.

Screenshot 2023-10-05 at 12 21 27

ofl/agbalumo/DESCRIPTION.en_us.html Outdated Show resolved Hide resolved
ofl/agbalumo/METADATA.pb Outdated Show resolved Hide resolved
ofl/agbalumo/OFL.txt Outdated Show resolved Hide resolved
@RosaWagner RosaWagner added the -- Needs manager's opinion from upper level label Oct 5, 2023
@RosaWagner
Copy link
Contributor

If the "development" panel doesn't work to link the issue to can add the issue number with a closing word to achieve the linking :)

@RosaWagner RosaWagner added the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label Oct 5, 2023
@davelab6
Copy link
Member

davelab6 commented Oct 5, 2023

Since the font is quite thick, we need to decide if it should have "One" appended to the name to be able to onboard other weights later.

I confirm this is intended as a single style display face, and if it is expanded in future with a range of weights, the design itself would be modified to be more suitable for text, and so would be a separate family "Agbalumo Pro" or so.

@eliheuer eliheuer added this to the 2023 Q4 milestone Oct 5, 2023
@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 6, 2023

Since the font is quite thick, we need to decide if it should have "One" appended to the name to be able to onboard other weights later.

This was resolved in various chats today, we are going to go ahead with onboarding this as just "Agbalumo" without "One" appended. The docs might need to be updated to make it clear this requirement isn't absolutely necessary and exceptions can be made.

Copy link
Collaborator Author

@eliheuer eliheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved all the issues brought up by Rosalie and Dave, making a new pull request soon for a second review.

@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 6, 2023

Updated

Agbalumo: Version 1.000; ttfautohint (v1.8.4) added


6a9a2d7: [gftools-packager] Agbalumo: Version 1.000; ttfautohint (v1.8.4) added

@eliheuer eliheuer force-pushed the gftools_packager_ofl_agbalumo branch from b49e64f to 6a9a2d7 Compare October 6, 2023 09:12
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

FontBakery report

fontbakery version: 0.9.2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[19] Agbalumo-Regular.ttf
WARN: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • WARN GF_TransLatin_Pinyin is almost fulfilled. Missing codepoints:

    • 0x1D3A (MODIFIER LETTER CAPITAL N)

    • 0x0114 (LATIN CAPITAL LETTER E WITH BREVE)

    • 0x012C (LATIN CAPITAL LETTER I WITH BREVE)

    • 0x014E (LATIN CAPITAL LETTER O WITH BREVE)

    • 0x0115 (LATIN SMALL LETTER E WITH BREVE)

    • 0x012D (LATIN SMALL LETTER I WITH BREVE)

    • 0x014F (LATIN SMALL LETTER O WITH BREVE)
      [code: missing-codepoints]

  • WARN GF_Latin_African is almost fulfilled. Missing codepoints:

    • 0xA7B3 (LATIN CAPITAL LETTER CHI)

    • 0x01EE (LATIN CAPITAL LETTER EZH WITH CARON)

    • 0x1E28 (LATIN CAPITAL LETTER H WITH CEDILLA)

    • 0xA726 (LATIN CAPITAL LETTER HENG)

    • 0xA740 (LATIN CAPITAL LETTER K WITH STROKE)

    • 0xA7AD (LATIN CAPITAL LETTER L WITH BELT)

    • 0x2C60 (LATIN CAPITAL LETTER L WITH DOUBLE BAR)

    • 0x2C62 (LATIN CAPITAL LETTER L WITH MIDDLE TILDE)

    • 0x0220 (LATIN CAPITAL LETTER N WITH LONG RIGHT LEG)

    • 0x0222 (LATIN CAPITAL LETTER OU)

    • 7 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

  • WARN GF_Latin_Beyond is almost fulfilled. Missing codepoints:

    • 0x03BB (GREEK SMALL LETTER LAMDA)

    • 0x03C7 (GREEK SMALL LETTER CHI)

    • 0x01EE (LATIN CAPITAL LETTER EZH WITH CARON)

    • 0x2C62 (LATIN CAPITAL LETTER L WITH MIDDLE TILDE)

    • 0x023E (LATIN CAPITAL LETTER T WITH DIAGONAL STROKE)

    • 0x01EF (LATIN SMALL LETTER EZH WITH CARON)

    • 0x02C0 (MODIFIER LETTER GLOTTAL STOP)

    • 0x0166 (LATIN CAPITAL LETTER T WITH STROKE)

    • 0x01F0 (LATIN SMALL LETTER J WITH CARON)

    • 0x0138 (LATIN SMALL LETTER KRA)

    • 8 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

  • WARN GF_TransLatin_Arabic is almost fulfilled. Missing codepoints:

    • 0x1E96 (LATIN SMALL LETTER H WITH LINE BELOW)

    • 0x1E97 (LATIN SMALL LETTER T WITH DIAERESIS)

    • 0x02BD (MODIFIER LETTER REVERSED COMMA)
      [code: missing-codepoints]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02B0 MODIFIER LETTER SMALL H: not included in any glyphset definition

  • U+02B7 MODIFIER LETTER SMALL W: not included in any glyphset definition

  • U+02BE MODIFIER LETTER RIGHT HALF RING: not included in any glyphset definition

  • U+02BF MODIFIER LETTER LEFT HALF RING: not included in any glyphset definition

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition

  • U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition

  • U+02D7 MODIFIER LETTER MINUS SIGN: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
    79 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic-ext, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i

    • i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Raphael Alegbeleye is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • M_gravecomb

    • a.alt2

    • a.alt5

    • acutecomb.narrow

    • ampersand.001

    • ampersand.003

    • ampersand.004

    • ampersand.005

    • ampersand.006

    • ampersand.007

    • 14 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: y	Contours detected: 2	Expected: 1

- Glyph name: AE	Contours detected: 3	Expected: 2

- Glyph name: yacute	Contours detected: 3	Expected: 2

- Glyph name: ydieresis	Contours detected: 4	Expected: 3

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: eogonek	Contours detected: 3	Expected: 2

- Glyph name: lslash	Contours detected: 2	Expected: 1

- Glyph name: OE	Contours detected: 3	Expected: 2

- Glyph name: Uogonek	Contours detected: 2	Expected: 1

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- 73 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 556 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 554:
plus

Width = 515:
less

Width = 521:
greater

Width = 565:
logicalnot

Width = 579:
plusminus

Width = 541:
multiply

Width = 548:
minus, divide

Width = 546:
approxequal

Width = 502:
lessequal

Width = 506:
greaterequal
[code: width-outliers]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • Eng (U+014A): B<<392.5,483.0>-<431.0,369.0>-<454.0,212.0>>/L<<454.0,212.0>--<458.0,292.0>> = 11.196769743469542

    • h (U+0068): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

    • hbar (U+0127): B<<254.5,418.5>-<245.0,379.0>-<237.0,346.0>>/B<<237.0,346.0>-<256.0,383.0>-<287.5,419.5>> = 13.554116225585668

    • hcircumflex (U+0125): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

    • ordfeminine (U+00AA): B<<226.0,293.5>-<226.0,297.0>-<227.0,301.0>>/B<<227.0,301.0>-<206.0,258.0>-<178.5,237.5>> = 11.993348723586983

    • uni021F (U+021F): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

    • uni0265 (U+0265): B<<321.5,68.0>-<333.0,114.0>-<343.0,154.0>>/B<<343.0,154.0>-<324.0,117.0>-<292.5,80.5>> = 13.144867617550734

    • uni02B0 (U+02B0): B<<207.0,529.0>-<198.0,496.0>-<189.0,467.0>>/B<<189.0,467.0>-<205.0,494.0>-<232.5,520.5>> = 13.409208558112896

    • uni1E23 (U+1E23): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

    • uni1E25 (U+1E25): B<<255.0,432.0>-<244.0,386.0>-<233.0,346.0>>/B<<233.0,346.0>-<252.0,383.0>-<283.5,419.5>> = 11.804859836651074

    • 5 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • summation (U+2211): L<<412.0,564.0>--<247.0,563.0>>

    • uni01A9 (U+01A9): L<<408.0,574.0>--<230.0,573.0>> [code: found-semi-vertical]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters should disappear in other cases, for example: ɉ̀ ɉ́ ɉ̂ ɉ̃ ɉ̄ ɉ̆ ɉ̇ ɉ̈ ɉ̉ ɉ̊ ɉ̋ ɉ̌ ɉ̍ ɉ̏ ɉ̐ ɉ̑ ɉ̒ ɉ̓ ɉ᷄ ɉ᷅

Your font fully covers the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Kom (Latn, 360,685 speakers), Avokaya (Latn, 100,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers), Ebira (Latn, 2,200,000 speakers), Nateni (Latn, 100,000 speakers), Aghem (Latn, 38,843 speakers), Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers), Ma’di (Latn, 584,000 speakers), Lugbara (Latn, 2,200,000 speakers), Basaa (Latn, 332,940 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dan (Latn, 1,099,244 speakers), Ejagham (Latn, 120,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers). [code: soft-dotted]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/agbalumo/Agbalumo-Regular.ttf
Dehinted Size 370.7kb
Hinted Size 423.2kb
Increase 52.4kb
Change 14.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/agbalumo [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 12 64 8 165 0
0% 0% 5% 26% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner removed -- Needs manager's opinion from upper level -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required labels Oct 6, 2023
@eliheuer
Copy link
Collaborator Author

eliheuer commented Oct 6, 2023

@RosaWagner About the designer credits, Raphael should be Principal Design, but Eben should be included as a secondary designer.

I included both Sorkin Type and Eben Sorkin in the credits because the font is hosted on the Sorkin Type GitHub, lists Sorkin Type as the manufacturer, and other similar fonts already on Google fonts do the same thing, I looked at Calistoga as an example: https://fonts.google.com/specimen/Calistoga/about

ColumnType is a label Raphael wants to use to release more fonts under. The ColumnType website is not live, and the only online presence I know of is an Instagram page with a few posts: https://www.instagram.com/columntype

@eliheuer eliheuer dismissed RosaWagner’s stale review October 9, 2023 19:21

The issues have been fixed

@RosaWagner
Copy link
Contributor

I see only one small issue so it won't block the merging, but maybe @eliheuer you can raise an issue upstream so it can be fixed in a next update.

There is an inconsistency between Ldot and L periodcentered.loclCAT.case;

  1. since the locl feature is making the substitution with periodcentered.loclCAT, Ldot is a bit useless here, it can be kept for backward compatibility or removed.
  2. L periodcentered.loclCAT.case L doesn't display the dot in the middle of the 2 L.

A good practice would be to achieve that through with sidebearing of periodcentered.loclCAT.case, then if Ldot is meant to stay, it can be a component of L periodcentered.loclCAT.case with automatic alignment to make sure both strings are consistent.

Screenshot 2023-10-10 at 09 20 03

@RosaWagner RosaWagner merged commit ca33c40 into main Oct 10, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_agbalumo branch October 10, 2023 07:26
@eliheuer
Copy link
Collaborator Author

Thanks! I filled an issue upstream. Eben and the designer are planning on a v 1.100 update this year, so I will try to make sure this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Agbalumo
3 participants