Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update push lists #7345

Merged
merged 8 commits into from
Mar 12, 2024
Merged

update push lists #7345

merged 8 commits into from
Mar 12, 2024

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Mar 4, 2024

No description provided.

@m4rc1e m4rc1e marked this pull request as draft March 4, 2024 15:59
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Mar 4, 2024

Setting to draft since I'll add a few more goodies.

to_sandbox.txt Show resolved Hide resolved
@emmamarichal
Copy link
Collaborator

Let's add the latest categorization tagging data to the main branch csv file and the csv file path to the to_sandbox list before we merge the lists this week.

@emmamarichal @m4rc1e

-> I added it, @m4rc1e please correct me if it's not the good way to add it!

@chrissimpkins
Copy link
Collaborator

Let's add the latest categorization tagging data to the main branch csv file and the csv file path to the to_sandbox list before we merge the lists this week.
@emmamarichal @m4rc1e

-> I added it, @m4rc1e please correct me if it's not the good way to add it!

Will need the data update in the csv file too

@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Mar 6, 2024

We'll need to define Workspace menu families for some Jacquard families. The design does not show up well in the menus:

jacquard

Going through the full list and will let you know which ones we will need to remove from the to_production list until we make this change.

to_production.txt Outdated Show resolved Hide resolved
to_production.txt Outdated Show resolved Hide resolved
to_production.txt Outdated Show resolved Hide resolved
@chrissimpkins
Copy link
Collaborator

We'll need to define Workspace menu families for some Jacquard families. The design does not show up well in the menus:

jacquard

Going through the full list and will let you know which ones we will need to remove from the to_production list until we make this change.

This involves all of the Jacquard families. Let's remove all of them from the to_prod list this week and I will work on the definition of the menu families for Workspace. I think that we should be able to move them into production next week. We'll do the same confirmation with the next list prep to confirm that they are gtg.

I can confirm that all of the Yarndings families are ready following the changes that we made in recent weeks. OK to ship all of those to prod.

I tested all of the other new families in the list and they are also ready to go. Jacquard families are the only ones that require a change before we merge this.

@emmamarichal
Copy link
Collaborator

@chrissimpkins For now, I blocked all the charted families, except Yarndings. I wait for your confirmation before remove them from the list.
How does Jacquarda Bastarada 9 Charted appear for example?

Screenshot 2024-03-07 at 09 58 01

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Mar 7, 2024

Family tags have been merged, #7370.

cc @chrissimpkins @emmamarichal

@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Mar 8, 2024

CSV data updated and Jacquard families were removed as we work on the internal changes necessary to support a Workspace font selection menu alternate. Ready to merge here after we address the CI fail:

https://github.com/google/fonts/actions/runs/8189168805/job/22393296093?pr=7345

@m4rc1e m4rc1e force-pushed the push-lists branch 2 times, most recently from ac5a1a8 to 2828b72 Compare March 11, 2024 10:37
@m4rc1e m4rc1e merged commit 3f7449f into main Mar 12, 2024
9 checks passed
@m4rc1e m4rc1e deleted the push-lists branch March 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants