Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bzlmod support for Bazel #950

Closed
chandlerc opened this issue Jan 27, 2024 · 6 comments · Fixed by #1308
Closed

Add bzlmod support for Bazel #950

chandlerc opened this issue Jan 27, 2024 · 6 comments · Fixed by #1308

Comments

@chandlerc
Copy link
Contributor

Bazel builds are moving towards a new modules system instead of the workspace files:
https://bazel.build/external/module

Filing this to track any work needed to add a module file for this project. I'll link to it from the request to add this project to the Bazel central registry.

@chandlerc chandlerc changed the title Add bzlmod support for Bazel 7 and later Add bzlmod support for Bazel Jan 27, 2024
chandlerc added a commit to chandlerc/fuzztest that referenced this issue Jan 27, 2024
These clients have different repository naming conventions, and the
exact match isn't needed here anyways so use a permissive regex.

This will need further changes to support building an actual `fuzztest`
Bazel module, likely called 'fuzztest`. That's tracked in issue google#950.

This at least unblocks current modules from depending on this repo.
@wffurr
Copy link

wffurr commented Apr 25, 2024

I have a draft CL for this issue, but it's hung up on the riegeli dependency, which requires a very old version of protobuf. I'm attempting to update riegeli to use a newer protobuf, but it's stuck on a weird build issue I don't understand.

@ussuri
Copy link
Collaborator

ussuri commented Apr 27, 2024

What's the build issue?

@xansec
Copy link

xansec commented May 14, 2024

I have a draft CL for this issue, but it's hung up on the riegeli dependency, which requires a very old version of protobuf. I'm attempting to update riegeli to use a newer protobuf, but it's stuck on a weird build issue I don't understand.

Not sure what issue you're having, but it looks like the latest riegeli was merged:
bazelbuild/bazel-central-registry#1844

@tpudlik
Copy link

tpudlik commented Jul 22, 2024

@wffurr could you share your draft CL? It would be great to see fuzztest in the BCR, and maybe the new riegeli version unblocks it!

@wffurr
Copy link

wffurr commented Jul 22, 2024

I haven't had a lot of time to work on this lately. The new Riegeli does fix the protobuf version issue, but the e2e tests fail due to some sandboxing issue with bzlmod I don't understand.

#1174 is the PR.

copybara-service bot pushed a commit that referenced this issue Aug 8, 2024
copybara-service bot pushed a commit that referenced this issue Aug 8, 2024
copybara-service bot pushed a commit that referenced this issue Aug 9, 2024
copybara-service bot pushed a commit that referenced this issue Aug 9, 2024
Closes #950.

PiperOrigin-RevId: 660832356
copybara-service bot pushed a commit that referenced this issue Aug 9, 2024
Closes #950.

PiperOrigin-RevId: 660832356
@udaya2899
Copy link

udaya2899 commented Aug 9, 2024

I patched @wffurr 's work and made it work in cl/660832356. This should fix this long-standing issue.

copybara-service bot pushed a commit that referenced this issue Aug 12, 2024
Closes #950.

PiperOrigin-RevId: 660832356
copybara-service bot pushed a commit that referenced this issue Aug 13, 2024
Closes #950.

PiperOrigin-RevId: 660832356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants