-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bzlmod support for Bazel #950
Comments
These clients have different repository naming conventions, and the exact match isn't needed here anyways so use a permissive regex. This will need further changes to support building an actual `fuzztest` Bazel module, likely called 'fuzztest`. That's tracked in issue google#950. This at least unblocks current modules from depending on this repo.
I have a draft CL for this issue, but it's hung up on the riegeli dependency, which requires a very old version of protobuf. I'm attempting to update riegeli to use a newer protobuf, but it's stuck on a weird build issue I don't understand. |
What's the build issue? |
Not sure what issue you're having, but it looks like the latest riegeli was merged: |
@wffurr could you share your draft CL? It would be great to see fuzztest in the BCR, and maybe the new riegeli version unblocks it! |
I haven't had a lot of time to work on this lately. The new Riegeli does fix the protobuf version issue, but the e2e tests fail due to some sandboxing issue with bzlmod I don't understand. #1174 is the PR. |
Closes #950. PiperOrigin-RevId: 660832356
Closes #950. PiperOrigin-RevId: 660832356
Closes #950. PiperOrigin-RevId: 660832356
Closes #950. PiperOrigin-RevId: 660832356
Closes #950. PiperOrigin-RevId: 660832356
I patched @wffurr 's work and made it work in cl/660832356. This should fix this long-standing issue. |
Closes #950. PiperOrigin-RevId: 660832356
Closes #950. PiperOrigin-RevId: 660832356
Bazel builds are moving towards a new modules system instead of the workspace files:
https://bazel.build/external/module
Filing this to track any work needed to add a module file for this project. I'll link to it from the request to add this project to the Bazel central registry.
The text was updated successfully, but these errors were encountered: