Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GL error report messages #883

Closed
ben-clayton opened this issue Aug 9, 2017 · 7 comments
Closed

Improve GL error report messages #883

ben-clayton opened this issue Aug 9, 2017 · 7 comments

Comments

@ben-clayton
Copy link
Contributor

We still have nonsense being displayed for GL errors. We need to fix this.
Example: Invalid value "value" for "variable"

@ben-clayton ben-clayton added this to the V0.9 (Beta) milestone Aug 9, 2017
@dsrbecky
Copy link
Contributor

dsrbecky commented Aug 9, 2017

My vote is that it is more important to get all the GL errors in pace first, rather make the code more complex by adding the custom error messages for a few. So I would just drop the text if it does not make sense, or just drop all the texts for now.

Let's do the simple thing first, and do the complex solution later please?

@dsrbecky
Copy link
Contributor

dsrbecky commented Aug 9, 2017

We could provide the URL for the online help for the given command - that should make it possible for the user to lookup what caused the error. It is not ideal, but it is simple to start with.

@dsrbecky
Copy link
Contributor

dsrbecky commented Aug 9, 2017

Also note that drivers can provide string messages together with the errors. Maybe we should use those for now?

@ben-clayton
Copy link
Contributor Author

I'm fine with removing the variable names from the message as a first step - that would lower the priority to p3.

@dsrbecky dsrbecky self-assigned this Aug 9, 2017
@dsrbecky
Copy link
Contributor

dsrbecky commented Aug 9, 2017

That should probably work - I will take a look.

@ben-clayton
Copy link
Contributor Author

Thanks!

@dsrbecky
Copy link
Contributor

#885

@dsrbecky dsrbecky added P3 and removed P1 labels Aug 10, 2017
@dsrbecky dsrbecky removed their assignment Aug 10, 2017
@dsrbecky dsrbecky changed the title Fix placeholder GL error report messages Improve GL error report messages Aug 10, 2017
@ben-clayton ben-clayton removed this from the V0.9 (Beta) milestone Aug 14, 2017
@ben-clayton ben-clayton modified the milestone: V1.0 Sep 6, 2017
@dsrbecky dsrbecky self-assigned this Sep 21, 2017
@dsrbecky dsrbecky reopened this Oct 3, 2017
@dsrbecky dsrbecky removed this from the V1.0 milestone Oct 3, 2017
@dsrbecky dsrbecky added enhancement and removed bug labels Oct 3, 2017
@dsrbecky dsrbecky added this to the V1.0 milestone Oct 3, 2017
@dsrbecky dsrbecky closed this as completed Oct 3, 2017
purvisa-at-google-com pushed a commit that referenced this issue Sep 29, 2022
The new debug.py script is meant to be used as a basis when running
one-off swarming tasks to diagnose failures.

Bug: n/a
Test: manual runs of debub.py on Swarming bots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants