Fix default group thumbs #1101
Merged
Fix default group thumbs #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsrbecky
approved these changes
Sep 14, 2017
|
Thanks |
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
Add feature and extension boilerplate. Capture and rebuild VkFramebufferAttachmentsCreateInfo and VkRenderPassAttachmentBeginInfo extension structs in vkCreateFramebuffer and vkCmdBeginRenderPass, respectively. Track the now-dynamic framebuffer image attachments as they are recorded (in CommandBufferObject) and submitted (in DrawInfo) instead of in the FramebufferObject. Tested with the imageless_framebuffer sample from google/vulkan_test_applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CommandTreeNodeUserData.Thumbnailis set toapi.CmdNoIDwhen there's no explicit thumbnail. Don't try to get thumbnails for these no-id IDs.