-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot: Add API option to subject upload. #1130
Conversation
cmd/robot/subject.go
Outdated
@@ -48,6 +48,7 @@ func init() { | |||
|
|||
type subjectUploadVerb struct { | |||
RobotOptions | |||
API string `help:"the api to capture, can be either gles or vulkan (default:gles)"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag system does support enums.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the pattern that gapit uses for accepting the API seen in cmd/gapit/flags.go. Should I change that instance as well to be an enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do, but you don't have to. That flag might become a list, in which case keeping-as-is is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fixed.
Allows user to specify the API of the uploaded subject as either gles (the default) or vulkan. Then stores it in the subject's hints to be used when tracing with gapit.
ef82d98
to
9d6dfbe
Compare
Commenting to get cla/google to re-run |
…#1130) which we don't need
Allows user to specify the API of the uploaded subject as either gles
(the default) or vulkan. Then stores it in the subject's hints to be
used when tracing with gapit.