Robot: Add API option to subject upload. #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
reviewed
Sep 22, 2017
cmd/robot/subject.go
Outdated
| @@ -48,6 +48,7 @@ func init() { | |||
|
|
|||
| type subjectUploadVerb struct { | |||
| RobotOptions | |||
| API string `help:"the api to capture, can be either gles or vulkan (default:gles)"` | |||
There was a problem hiding this comment.
The flag system does support enums.
There was a problem hiding this comment.
I was following the pattern that gapit uses for accepting the API seen in cmd/gapit/flags.go. Should I change that instance as well to be an enum?
There was a problem hiding this comment.
You can do, but you don't have to. That flag might become a list, in which case keeping-as-is is fine.
Allows user to specify the API of the uploaded subject as either gles (the default) or vulkan. Then stores it in the subject's hints to be used when tracing with gapit.
baldwinn860
force-pushed
the
add_subject_api
branch
from
ef82d98
to
9d6dfbe
Compare
ben-clayton
approved these changes
Sep 26, 2017
|
Commenting to get cla/google to re-run |
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
…#1130) which we don't need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to specify the API of the uploaded subject as either gles
(the default) or vulkan. Then stores it in the subject's hints to be
used when tracing with gapit.