Optimize PackageInfoService #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can drastically reduce icon encoding times.
Don't fetch all the packages to just search for a single package. Shaves off half a second or so.
Don't check again if you already just checked. Shaves off a second or so.
Reduce worst-case latency.
ben-clayton
force-pushed
the
opt-pkginfo
branch
from
78bbcec
to
d492248
Compare
pmuetschard
approved these changes
Sep 26, 2017
| Collections.sort(sorted, new Comparator<Counter>() { | ||
| @Override | ||
| public int compare(Counter a, Counter b) { | ||
| if (a.time < b.time) { return 1; } |
There was a problem hiding this comment.
return Float.compare(b.time, a.time);
| private final Counter counter; | ||
|
|
||
| private Scope(Counter counter) { | ||
| this.start = System.currentTimeMillis(); |
There was a problem hiding this comment.
You probably should use System.nanoTime, since System.currentTimeMillis may not be monotonic and has very loose guarantees.
| } else { | ||
| return mMap.get(pngBase64); | ||
| } | ||
| } finally { |
There was a problem hiding this comment.
You are undoing most of this change in the next commit. Maybe squash the 'add try, remove try' parts?
|
|
||
| /** | ||
| * Lookups the value from the cache using the given key. If the cache does not contain the value | ||
| * then the {@link Builder} will be used to create the value. |
There was a problem hiding this comment.
Add a comment that this is not thread safe.
There was a problem hiding this comment.
Made thread safe instead.
| private FileCache() { | ||
| } | ||
|
|
||
| static <K, V> Cache<K, V> create( |
| } | ||
| } | ||
|
|
||
| public V scopedBuild(K key) { |
| for (int n; (n = is.read(buf)) != -1; ) { | ||
| os.write(buf, 0, n); | ||
| } | ||
| os.flush(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces package info with icons from ~17 seconds down to 2.5s (warm cache), 8s (cold cache) on my test device.
Fixes: #1000