Close ssh tunnel when either end closes the connection #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
reviewed
Sep 7, 2018
| break | ||
| } | ||
| } | ||
| writer.Close() |
There was a problem hiding this comment.
Could we not just continue using io.Copy() and just close the writer then that finishes?
Qining
force-pushed
the
close-tunnel-either-side
branch
2 times, most recently
from
dab8fc1
to
e7bfac0
Compare
|
@AWoloszyn You are right, the previous code is exactly the same to the io.Copy. This one check the error message to ignore the errors from normal exit. |
AWoloszyn
approved these changes
Sep 11, 2018
So that when users tracing through SSH with a specific number of frames to capture, the connection will be closed after that number of frames are captured.
Qining
force-pushed
the
close-tunnel-either-side
branch
from
e7bfac0
to
6c79c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that when users tracing through SSH with a specific number of frames to capture, the connection will be closed after that number of frames are captured.