Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass on adding multi-planar images. #2691

Merged
merged 2 commits into from
May 23, 2019
Merged

First pass on adding multi-planar images. #2691

merged 2 commits into from
May 23, 2019

Conversation

AWoloszyn
Copy link
Contributor

@AWoloszyn AWoloszyn commented Mar 26, 2019 •
edited
Loading

Still TODO: UI work. This will be done in a follow-up.

ben-clayton
ben-clayton reviewed Apr 1, 2019
View reviewed changes
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me after a skim.

gapis/api/templates/mutate.go.tmpl
@@ -35,6 +35,7 @@
"github.com/google/gapid/gapis/replay/value"
"github.com/google/gapid/gapis/stringtable"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove.

@AWoloszyn AWoloszyn merged commit c107b16 into google:master May 23, 2019
@AWoloszyn AWoloszyn deleted the mp-images branch May 23, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-clayton ben-clayton ben-clayton left review comments

@pau-baiget pau-baiget pau-baiget approved these changes

@pmuetschard pmuetschard Awaiting requested review from pmuetschard

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AWoloszyn @ben-clayton @pau-baiget @googlebot