Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating primitive names #41

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Updating primitive names #41

merged 1 commit into from
Aug 2, 2022

Conversation

FaragElsayed2
Copy link
Collaborator

Fixes google/globalfoundries-pdk-libs-gf180mcu_fd_pr#1

  • Renaming all primitives with its new name except resistors.

atorkmabrains
atorkmabrains approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes made and I approve them.

@mithro mithro changed the title Updating pr names Updating primitive names Aug 2, 2022
mithro
mithro approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FYI - I did notice #42

@mithro mithro merged commit 3cd88ef into google:main Aug 2, 2022
@mithro mithro deleted the prim_naming branch August 2, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

@atorkmabrains atorkmabrains atorkmabrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
3 participants
@FaragElsayed2 @mithro @atorkmabrains