Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed cluster discovery was not returning an error #104

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Failed cluster discovery was not returning an error #104

merged 4 commits into from
Jul 25, 2022

Conversation

mikouaj
Copy link
Member

@mikouaj mikouaj commented Jul 25, 2022

Lack of error on return resulted i.e. in a green Cloud Run job on failure

ewojtach
ewojtach approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@ewojtach ewojtach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikouaj mikouaj merged commit ca5cffc into main Jul 25, 2022
@mikouaj mikouaj deleted the failed-discovery-noErr-fix branch July 25, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewojtach ewojtach ewojtach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikouaj @ewojtach