Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted fetching clusters logic and added API error handling #117

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Extracted fetching clusters logic and added API error handling #117

merged 3 commits into from
Aug 17, 2022

Conversation

mikouaj
Copy link
Member

@mikouaj mikouaj commented Aug 8, 2022

  • refactor in app package: moved cluster check related functions to separate file
  • extracted fetch cluster data logic to getClusterData func

@mikouaj mikouaj requested a review from ewojtach August 8, 2022 12:54
@mikouaj mikouaj linked an issue Aug 8, 2022 that may be closed by this pull request
Tool should not fail on a discovered cluster that does not exist #113
Closed
@mikouaj mikouaj added the bug Something isn't working label Aug 9, 2022
@mikouaj mikouaj merged commit 591fcc5 into main Aug 17, 2022
@mikouaj mikouaj deleted the cluster-404-fix branch August 17, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewojtach ewojtach Awaiting requested review from ewojtach

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tool should not fail on a discovered cluster that does not exist
1 participant
@mikouaj