Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating primitives names for 'pmos' devices in lvs gds files #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FaragElsayed2
Copy link
Collaborator

@FaragElsayed2 FaragElsayed2 commented Aug 11, 2022

Fixes #1

  • Renaming pmos devices with its new name in the gds files used in LVS testing under the following directory:

    • globalfoundries-pdk-libs-gf180mcu_fd_pr/rules/klayout/lvs/testing/testcases/

Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro I'm approving this change.

@FaragElsayed2 FaragElsayed2 changed the title Updating primitives names part18 Updating primitives names for 'pmos' devices in lvs gds files Aug 21, 2022
@FaragElsayed2
Copy link
Collaborator Author

FaragElsayed2 commented Aug 31, 2022

@mithro Changes are completed including cap_mim as you agreed with @atorkmabrains

@proppy
Copy link
Member

proppy commented Sep 15, 2022

the diff between sample_pfet_03v3.gds and sample_pmos_3p3.gds is quite big:

💀 ls -alh *.gds
-rw-r----- 1 proppy primarygroup 2.2M Sep 15 16:03 sample_pfet_03v3.gds
-rw-r----- 1 proppy primarygroup 2.2M Sep 15 16:03 sample_pmos_3p3.gds
🍫 xdelta delta -0 sample_pmos_3p3.gds sample_pfet_03v3.gds patch.xdelta
🍙 ls -alh patch.xdelta 
-rw-r----- 1 proppy primarygroup 1.3M Sep 15 16:11 patch.xdelta

is that expected? or where other modification included with this change (beside renaming the cells)

@atorkmabrains
Copy link
Collaborator

@proppy Yes, that's expected. Renaming the the cells affect the binary files.

@proppy
Copy link
Member

proppy commented Sep 16, 2022

Should we make a GDS XOR between the two to verify that the layout doesn't get altered?

@atorkmabrains
Copy link
Collaborator

@proppy Yes, please. You could do that and tell me if there any changes in the layout.

proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
3 participants