Update ngspice/xyce regression tests README to include information about how to interpret the results #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohamed Kassem <mkkassem@users.noreply.github.com>
Signed-off-by: Mohamed Kassem <mkkassem@users.noreply.github.com>
Signed-off-by: Mohamed Kassem <mkkassem@users.noreply.github.com>
Signed-off-by: Mohamed Kassem <mkkassem@users.noreply.github.com>
mkkassem
changed the title
proppy
reviewed
Nov 14, 2022
| 2. measured folder that contains measured data used in regression. | ||
| 3. simulated folder that contains simulated data used in regression. | ||
| 4. netlists folder that contains spice files used in simulation. | ||
| It's important to check the `run_log.log` to see the error per device. |
There was a problem hiding this comment.
nit: can we give an idea of what the acceptable pourcentage rate is?
proppy
reviewed
Nov 14, 2022
| 2. measured folder that contains measured data used in regression. | ||
| 3. simulated folder that contains simulated data used in regression. | ||
| 4. netlists folder that contains spice files used in simulation. | ||
| It's important to check the `run_log.log` to see the error per device. |
There was a problem hiding this comment.
nit: can we give an idea of what the acceptable pourcentage rate is?
proppy
reviewed
Nov 14, 2022
|
|
||
| ## Regression Usage | ||
|
|
||
| To make a full test for GF180nm models-ngspice, you could use the following command in testing directory: | ||
| - To make a full test for GF180nm models-ngspice, you could use the following command in testing directory: |
proppy
reviewed
Nov 14, 2022
| ## Regression Usage | ||
|
|
||
| To make a full test for GF180nm models-xyce, you could use the following command in testing directory: | ||
| - To make a full test for GF180nm models-xyce, you could use the following command in testing directory: |
proppy
changed the title
proppy
pushed a commit
to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr
that referenced
this pull request
Feb 6, 2023
Ngspice regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohamed Kassem mkkassem@users.noreply.github.com
Fixes google/gf180mcu-pdk#94