Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating prim names #7

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Updating prim names #7

merged 1 commit into from
Aug 3, 2022

Conversation

FaragElsayed2
Copy link
Collaborator

Fixes google/globalfoundries-pdk-libs-gf180mcu_fd_pr#1

  • Renaming all primitives with its new name except resistors.

@google-cla
Copy link

google-cla bot commented Aug 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and approve it for merge.

@RTimothyEdwards
Copy link
Collaborator

When is this going to be done for the 9t library? And is there a list of name translations somewhere?

@mithro
Copy link
Contributor

mithro commented Aug 3, 2022

The mapping can be found @ https://bit.ly/gf180mcu-names

I believe @atorkmabrains has a complete mapping.

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mithro mithro merged commit 786c50c into google:main Aug 3, 2022
@mithro mithro deleted the prim_naming branch August 3, 2022 15:27
@RTimothyEdwards
Copy link
Collaborator

@mithro : FYI, the document is incomplete as it does not reflect all process variants; There must be metal4, 5, and 6 resistors and the top metal resistor depends on the variant's definition of top metal (which can be anything from metal3 to metal6).

I note that the resistors have not been changed and the name translations are marked with question marks. Will this be resolved promptly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
4 participants