Use gflags ALIAS instead of ${gflags_XXX} vars #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gflags project updated their CMake config last year with a
`gflags` ALIAS target. This can be used instead of the legacy
`${gflags_LIBRARIES}` and `${gflags_INCLUDE_DIRS}` variables. It also
looks cleaner.
Fixes #198
|
Which gflags version introduced the alias? This needs to be set here. |
|
Updated with gflags version. |
|
Any additional comments @sergiud? |
|
@v1bri Looks good to me now. |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Use gflags ALIAS instead of ${gflags_XXX} vars
keir
pushed a commit
to ceres-solver/ceres-solver
that referenced
this pull request
Dec 12, 2019
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. Furthermore use the find_dependency() [4] cmake function specifically created for cmake-config files. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 [4] https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. Furthermore use the find_dependency() [4] cmake function specifically created for cmake-config files. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 [4] https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. Furthermore use the find_dependency() [4] cmake function specifically created for cmake-config files. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 [4] https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. Furthermore use the find_dependency() [4] cmake function specifically created for cmake-config files. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 [4] https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
mystorm16
pushed a commit
to mystorm16/ceres-solver
that referenced
this pull request
May 21, 2024
Update the usage of Google Flags (gflags) library the same way Glog updated it [1]. This pushes the minimum required gflags version to v2.2.0. Remove the ceres specific define of CERES_GFLAGS_NAMESPACE and directly use GFLAGS_NAMESPACE defined in gflags/gflags_declare.h [2]. In CeresConfig.cmake the hard coded paths for gflags are ommited. Instead we rely on the gflagsConfig file to get closer to a relocatable CeresConfig.cmake. Furthermore use the find_dependency() [4] cmake function specifically created for cmake-config files. This change builds upon the explicit PUBLIC/PRIVATE link change [3]. [1] google/glog#199 [2] https://github.com/gflags/gflags/blob/d9b184bd0026b16bb4c2fded75d56fb2cce50d66/src/gflags_declare.h.in#L43 [3] https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16220 [4] https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html Change-Id: I9861a2699f2702bf1a5e99d07863a7e6639b7c39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gflags project updated their CMake config last year with a
gflagsALIAS target. This can be used instead of the legacy${gflags_LIBRARIES}and${gflags_INCLUDE_DIRS}variables. It also looks cleaner.Fixes #198