Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gflags to latest master #277

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Update gflags to latest master #277

merged 1 commit into from
Jan 4, 2018

Conversation

drigz
Copy link
Member

@drigz drigz commented Dec 19, 2017

This means that gflags no longer leaks config.h (gflags/gflags@57ceb0e),
so I had to fix a bug in glog.bzl where config.h is generated at the wrong path.

I also switched to the best-practice for depending on git repositories,
ie using http_archive with a mirror.

@iirina For Bazel review.

This means that gflags no longer leaks config.h, so I had to fix a bug
in glog.bzl where config.h is generated at the wrong path.

I also switched to the best-practice for depending on git repositories,
ie using http_archive with a mirror.
@drigz drigz merged commit bffb4a6 into google:master Jan 4, 2018
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants