Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused variable warning in GCC #412

Merged
merged 1 commit into from
Dec 31, 2018
Merged

Fix unused variable warning in GCC #412

merged 1 commit into from
Dec 31, 2018

Conversation

pwnall
Copy link
Member

@pwnall pwnall commented Dec 26, 2018

kAlign is only used the #ifdef / #else branch, so GCC complains if both GLOG_THREAD_LOCAL_STORAGE and HAVE_ALIGNED_STORAGE are defined.

@sergiud sergiud merged commit e6939aa into google:master Dec 31, 2018
@pwnall
Copy link
Member Author

pwnall commented Jan 3, 2019

@sergiud Thank you very much for the quick review!

@pwnall pwnall deleted the fix_warn branch January 3, 2019 01:27
@sergiud
Copy link
Collaborator

sergiud commented Jan 3, 2019

@pwnall You're welcome!

durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
@sergiud
Merge pull request google#412 from pwnall/fix_warn
9a30104 
Fix unused variable warning in GCC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwnall @sergiud @googlebot