Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused parameter warning on gcc. #540

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Fix unused parameter warning on gcc. #540

merged 1 commit into from
Oct 1, 2020

Conversation

pwnall
Copy link
Member

@pwnall pwnall commented Apr 11, 2020

Fixes #493

@sergiud
Copy link
Collaborator

sergiud commented Sep 29, 2020

Could you please resolve the conflict?

@sergiud sergiud self-assigned this Sep 29, 2020
@pwnall
Copy link
Member Author

pwnall commented Sep 30, 2020

@sergiud Done. Thank you for taking a look at this PR!

@sergiud sergiud merged commit d516278 into google:master Oct 1, 2020
@pwnall pwnall deleted the fix-uv-warn branch October 1, 2020 08:49
@pwnall
Copy link
Member Author

pwnall commented Oct 1, 2020

Thank you very much for the quick review!

@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sergiud sergiud

Labels
cla: yes
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Including glog/logging.h triggers -Wunused-parameter on g++
3 participants
@pwnall @sergiud @googlebot