Clarify public key format and add tests #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public key format specified in RFD002 mandated standard Base64-encoding, but the implementation uses URL-safe Base64. We want to use the URL-safe format to be consistent with the challenge encoding. This also introduces a dedicated test for the login module.
Introduce a new config file only for testing so that we can add a public key to it without adding it to the file that is packaged/installed.
vvidic
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit da09fec (HEAD -> public-key-format, burgerdev/public-key-format)
Author: Markus Rudy markusrudy@google.com
Date: Mon Jan 16 16:29:24 2023 +0100
commit 82d3e66
Author: Markus Rudy markusrudy@google.com
Date: Mon Jan 16 13:58:06 2023 +0100