Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify public key format and add tests #144

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Clarify public key format and add tests #144

merged 2 commits into from
Jan 18, 2023

Commits on Jan 16, 2023

  1. Clarify format of public key at rest 

    The public key format specified in RFD002 mandated standard
Base64-encoding, but the implementation uses URL-safe Base64. We want to
use the URL-safe format to be consistent with the challenge encoding.

This also introduces a dedicated test for the login module.
    @burgerdev
    burgerdev committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    82d3e66 View commit details
    Browse the repository at this point in the history

  2. Test all supported config file keys 

    Introduce a new config file only for testing so that we can add a public
key to it without adding it to the file that is packaged/installed.
    @burgerdev
    burgerdev committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    da09fec View commit details
    Browse the repository at this point in the history