Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstore: provide the user with query plan information #1874

Merged
merged 9 commits into from
Apr 23, 2019

Conversation

jba
Copy link
Contributor

@jba jba commented Apr 22, 2019

Let the user ask whether a query used an index, or did a table scan.

This can help users optimize queries.

Fixes #1832.

Let the user ask whether a query used an index, or did a table scan.

This can help users optimize queries.

Fixes google#1832.
@jba jba requested review from shantuo and vangent April 22, 2019 20:34
@googlebot googlebot added the cla: yes Google CLA has been signed! label Apr 22, 2019
@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #1874 into master will decrease coverage by 0.1%.
The diff coverage is 58.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   74.17%   74.06%   -0.11%     
==========================================
  Files          80       80              
  Lines        8862     8895      +33     
==========================================
+ Hits         6573     6588      +15     
- Misses       1816     1834      +18     
  Partials      473      473
Impacted Files Coverage Δ
internal/docstore/mongodocstore/query.go 0% <0%> (ø) ⬆️
internal/docstore/firedocstore/query.go 75.93% <100%> (+0.26%) ⬆️
internal/docstore/memdocstore/query.go 74.64% <100%> (+0.73%) ⬆️
internal/docstore/dynamodocstore/dynamo.go 68.62% <50%> (-5.13%) ⬇️
internal/docstore/query.go 71.01% <55.55%> (-2.32%) ⬇️
internal/docstore/dynamodocstore/query.go 80.82% <81.81%> (+1.47%) ⬆️
runtimevar/filevar/filevar.go 87.15% <0%> (+1.83%) ⬆️
internal/retry/retry.go 100% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f087c9c...ecff3f7. Read the comment docs.

internal/docstore/dynamodocstore/query.go Outdated Show resolved Hide resolved
internal/docstore/query.go Outdated Show resolved Hide resolved
@jba
Copy link
Contributor Author

jba commented Apr 22, 2019

PTAL.

internal/docstore/dynamodocstore/query.go Show resolved Hide resolved
internal/docstore/firedocstore/query.go Outdated Show resolved Hide resolved
internal/docstore/query.go Outdated Show resolved Hide resolved
@jba jba merged commit 838b24b into google:master Apr 23, 2019
@jba jba deleted the docstore-query-plan branch April 23, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamodocstore: support any query
4 participants