Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/rabbit: remove stale TODO #1884

Merged
merged 1 commit into from
Apr 23, 2019
Merged

pubsub/rabbit: remove stale TODO #1884

merged 1 commit into from
Apr 23, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Apr 23, 2019

See my comment on the bug.

@vangent vangent requested a review from jba April 23, 2019 16:06
@googlebot googlebot added the cla: yes Google CLA has been signed! label Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #1884 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   74.01%   74.01%   -0.01%     
==========================================
  Files          80       80              
  Lines        8895     8898       +3     
==========================================
+ Hits         6584     6586       +2     
  Misses       1838     1838              
- Partials      473      474       +1
Impacted Files Coverage Δ
pubsub/rabbitpubsub/rabbit.go 74% <ø> (ø) ⬆️
mysql/cloudmysql/cloudmysql.go 70.83% <0%> (-3.08%) ⬇️
postgres/cloudpostgres/cloudpostgres.go 20.22% <0%> (-0.47%) ⬇️
internal/retry/retry.go 100% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11dbf5f...1b899fb. Read the comment docs.

@vangent vangent merged commit 26698ec into google:master Apr 23, 2019
@vangent vangent deleted the cleanup branch April 23, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants