Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/awssnssqs: fix docs/examples/tests to show SNS ARN in path, not hostname #2648

Merged
merged 1 commit into from Aug 14, 2019

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Aug 14, 2019

Fixes #2647.

@vangent vangent requested a review from shantuo August 14, 2019 16:46
@googlebot googlebot added the cla: yes Google CLA has been signed! label Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #2648 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
- Coverage   66.97%   66.95%   -0.02%     
==========================================
  Files         134      134              
  Lines       15584    15584              
==========================================
- Hits        10437    10434       -3     
- Misses       4394     4399       +5     
+ Partials      753      751       -2
Impacted Files Coverage Δ
pubsub/awssnssqs/awssnssqs.go 85.45% <ø> (ø) ⬆️
server/health/sqlhealth/sqlhealth.go 61.9% <0%> (-19.05%) ⬇️
pubsub/pubsub.go 93.41% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f6c05...5134f95. Read the comment docs.

@vangent vangent merged commit f79acfd into google:master Aug 14, 2019
@vangent vangent deleted the snsurl branch August 14, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub/awssnssqs: URL scheme broken by go 1.12.8
3 participants