pubsub/awssnssqs: Add support for setting FIFO message metadata #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for setting metadata in the message when publishing to AWS SNS FIFO Topics and AWS SQS FIFO queues. Closes google#3434
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3435 +/- ##
==========================================
+ Coverage 73.26% 73.31% +0.05%
==========================================
Files 113 113
Lines 14897 14921 +24
==========================================
+ Hits 10914 10940 +26
+ Misses 3207 3206 -1
+ Partials 776 775 -1 ☔ View full report in Codecov by Sentry. |
vangent
approved these changes
May 31, 2024
|
Thanks for the contribution! |
|
FYI the SQSv2 test turned out to be flaky, it sets 2 attributes in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3434
I've also added tests to cover this change, and generated new replay files for the tests.