Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust for reflect.Type.NumMethod change in Go1.16 #240

Merged
merged 1 commit into from Oct 20, 2020
Merged

Adjust for reflect.Type.NumMethod change in Go1.16 #240

merged 1 commit into from Oct 20, 2020

Commits on Oct 20, 2020

  1. Adjust for reflect.Type.NumMethod change in Go1.16 

    In Go1.16, the reflect.Type.NumMethod method will no longer report
unexported fields, matching the documented behavior on the method.
This means that t.NumMethod() == 0 is no longer a reliable means
to detect whether an interface type is the empty interface or not.
Fix the code to check whether the empty interface itself implements
the target type.
    @dsnet
    dsnet committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    9f49ed6 View commit details
    Browse the repository at this point in the history