Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xerrors dependency #292

Merged
merged 1 commit into from Apr 26, 2022
Merged

Remove xerrors dependency #292

merged 1 commit into from Apr 26, 2022

Conversation

catatsuy
Copy link
Contributor

Versions older than Go 1.13 are no longer in use. Remove unnecessary dependencies.

@dsnet
Copy link
Collaborator

dsnet commented Apr 23, 2022

For my @tailscale work, we only support the latest Go version. So this SGTM.

I'll leave it to @neild to make the call on what's the latest version we want to support here.

@dsnet dsnet requested a review from neild April 23, 2022 08:18
@dsnet dsnet changed the title remove xerrors Remove xerrors dependency Apr 23, 2022
@mvdan
Copy link

mvdan commented Apr 23, 2022

Oh wow, you even still test on Go 1.11.x :)

I was coming here to suggest that you drop ancient Go versions at this point, so I'm happy to see this PR. It would be nice to drop xerrors as an indirect dependency from a few of my projects.

neild
neild approved these changes Apr 25, 2022
Versions older than Go 1.13 are no longer in use. Remove unnecessary
dependencies.
@dsnet
Copy link
Collaborator

dsnet commented Apr 26, 2022

I think we can merge this. For some reason GitHub Actions is trying to run on 1.11 and 1.12 even though they no longer exist in the .yml file.

@neild neild merged commit 63c2960 into google:master Apr 26, 2022
13 checks passed
@catatsuy
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants