-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a way to create an image from scratch. #48
Comments
I think we want two constructs:
WDYT? |
We need more than just append, although I guess a "SetLayers" call could be constructed out of a series of appends... If we also had something to set the Config, I think that would be enough. Then modifying the Config from an existing Image would look like: Create a scratch.Image, set the Config on that. |
|
I retract my previous statement (I see it now), singletons are fine. :) |
@dlorenc Why not just take a slice of layers to append? :) |
Yeah that works, we just need a way to also set Config independently. I'm not a big fan of the way it happens in Python, with overrides being tacked onto the append. |
What was the rationale for making |
That necessitates eager fetching, there is signficant performance advantage to laziness. e.g. This code should be able to copy an image between two repositories on the same registry (via mounting) without ever hitting the |
What if fields from blobs were only populated after calling some method? How large are config blobs expected to get? |
This adds a special singleton for empty.Image, which serves a similar purpose to "FROM scratch" in the land of Dockerfiles. In isolation this isn't particularly interesting, but it provides a foundation on top of which subsequent utilities may build. Related to: google#48
This adds a special singleton for empty.Image, which serves a similar purpose to "FROM scratch" in the land of Dockerfiles. In isolation this isn't particularly interesting, but it provides a foundation on top of which subsequent utilities may build. Related to: #48
Thoughts on the name: parts.Image?
The idea would be a constructor that takes an ordered list of layers and a config file, and assembles them into an Image. This would be useful for modifying the config of an existing image, modifying layers, or other mutation operations.
The text was updated successfully, but these errors were encountered: