Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate crane options through gcrane cp -r #1127

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

Missed this when refactoring a while back. We want options to get
proagated down into the image copying logic.

Missed this when refactoring a while back. We want options to get
proagated down into the image copying logic.
@codecov-commenter
Copy link

Codecov Report

Merging #1127 (750f471) into main (486e71f) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files         108      108           
  Lines        7798     7798           
=======================================
  Hits         5853     5853           
  Misses       1380     1380           
  Partials      565      565           
Impacted Files Coverage Δ
pkg/gcrane/copy.go 84.73% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486e71f...750f471. Read the comment docs.

@imjasonh imjasonh merged commit b5cf9c4 into google:main Sep 21, 2021
jonjohnsonjr added a commit to jonjohnsonjr/go-containerregistry that referenced this pull request Dec 28, 2021
Missed this when refactoring a while back. We want options to get
proagated down into the image copying logic.
jonjohnsonjr added a commit that referenced this pull request Dec 28, 2021
Missed this when refactoring a while back. We want options to get
proagated down into the image copying logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants