Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the control flow for manifests and blobs. #1157

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

mattmoor
Copy link
Collaborator

I noticed that these functions were giant switch statements without the switch, they should also be using http.MethodFoo instead of constants.

I noticed that these functions were giant switch statements without the `switch`, they should also be using `http.MethodFoo` instead of constants.
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #1157 (86dfaa8) into main (b0e827a) will decrease coverage by 0.18%.
The diff coverage is 83.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   75.40%   75.22%   -0.19%     
==========================================
  Files         108      108              
  Lines        7824     7850      +26     
==========================================
+ Hits         5900     5905       +5     
- Misses       1361     1379      +18     
- Partials      563      566       +3     
Impacted Files Coverage Δ
pkg/registry/blobs.go 88.52% <81.57%> (-11.48%) ⬇️
pkg/registry/manifest.go 94.14% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e827a...86dfaa8. Read the comment docs.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@mattmoor mattmoor merged commit e7cd6af into google:main Oct 26, 2021
@mattmoor mattmoor deleted the pkg-registry branch October 26, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants