Bump acr cred helper dep #1247
Bump acr cred helper dep #1247
Conversation
This picks up chrismellard/docker-credential-acr-env#2 to fix hanging behavior when checking to see whether the ACR cred helper could be used to auth against a registry.
Codecov Report
@@ Coverage Diff @@
## main #1247 +/- ##
=======================================
Coverage 73.77% 73.77%
=======================================
Files 111 111
Lines 8285 8285
=======================================
Hits 6112 6112
Misses 1571 1571
Partials 602 602 Continue to review full report at Codecov.
|
|
/lgtm |
| @@ -10,49 +10,49 @@ replace ( | |||
|
|
|||
| require ( | |||
| github.com/google/go-containerregistry v0.8.1-0.20220110151055-a61fd0a8e2bb | |||
| github.com/google/go-containerregistry/pkg/authn/k8schain v0.0.0-20211223213658-2874338840a6 | |||
| github.com/google/go-containerregistry/pkg/authn/k8schain v0.0.0-20220114205711-890d5b362eb8 | |||
There was a problem hiding this comment.
I believe you'll need to update this in a separate PR
There was a problem hiding this comment.
Actually - probably not worth doing this here until k8s chain update merges
There was a problem hiding this comment.
I'm not sure we need to do this in another PR, since it's just replaced above. If downstream deps who don't respect the replace are broken by this (I think that's what you're describing?), we should figure out a way to capture that in a presubmit to prevent future breakages.
In any case, I can go get -u again after this merges. I'm kinda hating all these interdependent modules in this repo 🤦 .
There was a problem hiding this comment.
In any case, I can go get -u again after this merges.
Oh nm - I didn't see the replace directive. That's not necessary then. It would be If you want krane to be go install-able.
I'm kinda hating all these interdependent modules in this repo 🤦 .
Yeah the explicit refs are not fun - I'll open a go issue ;)
This update includes the fix in the ACR (Azure) cred helper to honor timeouts and skip attempting to acquire credentials if the registry URL is not ACR/MCR. ACR Helper Fix: chrismellard/docker-credential-acr-env#2 K8schain Fix: google/go-containerregistry#1247 Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
This update includes the fix in the ACR (Azure) cred helper to honor timeouts and skip attempting to acquire credentials if the registry URL is not ACR/MCR. ACR Helper Fix: chrismellard/docker-credential-acr-env#2 K8schain Fix: google/go-containerregistry#1247 Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 76f69fd)
This update includes the fix in the ACR (Azure) cred helper to honor timeouts and skip attempting to acquire credentials if the registry URL is not ACR/MCR. ACR Helper Fix: chrismellard/docker-credential-acr-env#2 K8schain Fix: google/go-containerregistry#1247 Signed-off-by: hasheddan <georgedanielmangum@gmail.com> (cherry picked from commit 76f69fd)
This picks up chrismellard/docker-credential-acr-env#2 to fix hanging behavior when checking to see whether the ACR cred helper could be used to auth against a registry.