Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output option to mutate to save to a tar file and not push to a registry (same as append) #1257

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

ehmm
Copy link
Contributor

@ehmm ehmm commented Jan 23, 2022

Support passing crane mutate an output as a tar. Append has it and it is useful for all kinds of more complex build and push flows

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #1257 (633db09) into main (890d5b3) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files         111      111           
  Lines        8285     8286    +1     
=======================================
+ Hits         6112     6113    +1     
  Misses       1571     1571           
  Partials      602      602           
Impacted Files Coverage Δ
pkg/v1/layout/write.go 48.88% <40.00%> (-0.48%) ⬇️
pkg/authn/keychain.go 85.48% <100.00%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1283f38...633db09. Read the comment docs.

@ehmm
Copy link
Contributor Author

ehmm commented Jan 27, 2022

@imjasonh can you please review?

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, curious if @jonjohnsonjr has any feedback.

@ehmm
Copy link
Contributor Author

ehmm commented Feb 21, 2022

Pinging @jonjohnsonjr

@jonjohnsonjr jonjohnsonjr merged commit 17d8b10 into google:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants