Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8schain README -- don't recommend modifting authn.DefaultKeyc… #1267

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

imjasonh
Copy link
Collaborator

…hain

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #1267 (92391a8) into main (cb47374) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1267   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files         111      111           
  Lines        8289     8289           
=======================================
  Hits         6116     6116           
  Misses       1571     1571           
  Partials      602      602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb47374...92391a8. Read the comment docs.

@imjasonh
Copy link
Collaborator Author

This questionable advice was discovered via kyverno/kyverno#3088 which resulted in ever-growing MultiKeychains, and memory leaks.

If this becomes a problem we might consider deprecating the mutable authn.DefaultKeychain and instead preferring a public method that returns an immutable Keychain impl.

@imjasonh imjasonh merged commit a12c848 into google:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants