Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOF to remote default retry predicate #1268

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

We see EOF when the server closes a connection without sending an
appropriate "Connection: close" header. The http Client attempts to
reuse a connection, but it fails with EOF because that connection is
closed. For idempotent requests, the http client will handle this for
us, but because this is a POST request, we just get the EOF back.

We see EOF when the server closes a connection without sending an
appropriate "Connection: close" header. The http Client attempts to
reuse a connection, but it fails with EOF because that connection is
closed. For idempotent requests, the http client will handle this for
us, but because this is a POST request, we just get the EOF back.
@codecov-commenter
Copy link

Codecov Report

Merging #1268 (c098a27) into main (a12c848) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files         111      111           
  Lines        8289     8289           
=======================================
  Hits         6116     6116           
  Misses       1571     1571           
  Partials      602      602           
Impacted Files Coverage Δ
pkg/v1/remote/options.go 69.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12c848...c098a27. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit a83d6e9 into google:main Jan 26, 2022
@jonjohnsonjr jonjohnsonjr deleted the eof branch January 26, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants