Eagerly fetch image ID in daemon.Image #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, daemon.Image is so lazy that non-existent images don't return an error. This changes ensures that the image actually exists by asking the daemon for its Image ID.
imjasonh
approved these changes
Jan 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #1272 +/- ##
=======================================
Coverage 73.91% 73.92%
=======================================
Files 111 111
Lines 8332 8345 +13
=======================================
+ Hits 6159 6169 +10
- Misses 1571 1573 +2
- Partials 602 603 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, daemon.Image is so lazy that non-existent images don't return
an error. This changes ensures that the image actually exists by asking
the daemon for its Image ID.
Fixes #1186