Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include blob existence checks in retries #1307

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

jonjohnsonjr
Copy link
Collaborator

Currently we just fail outright if the registry returns a 500 during a
blob HEAD because it's not included in the retry logic. This is not
ideal, especially in cases where an upload actually succeeded but we
never got a response from the server so we're re-uploading a blob for no
reason.

Currently we just fail outright if the registry returns a 500 during a
blob HEAD because it's not included in the retry logic. This is not
ideal, especially in cases where an upload actually succeeded but we
never got a response from the server so we're re-uploading a blob for no
reason.
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2022

Codecov Report

Merging #1307 (aa088a9) into main (86e1c81) will increase coverage by 0.05%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   74.01%   74.07%   +0.05%     
==========================================
  Files         112      112              
  Lines        8386     8386              
==========================================
+ Hits         6207     6212       +5     
+ Misses       1575     1570       -5     
  Partials      604      604              
Impacted Files Coverage Δ
pkg/v1/remote/write.go 64.82% <84.21%> (ø)
pkg/v1/remote/options.go 74.03% <0.00%> (+4.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e1c81...aa088a9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants