Don't parse challenge's scopes, put them first #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to work around some interesting behavior from DockerHub. > This query parameter should be specified multiple times if there is > more than one scope entry from the WWW-Authenticate header. https://docs.docker.com/registry/spec/auth/token/#requesting-a-token It would stand to reason that we shouldn't specify scope multiple times if there is only one (space-separated) scope in the header.
jonjohnsonjr
force-pushed
the
stupid-scopey-flanders
branch
from
71b022f
to
83cdb7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 112 112
Lines 8386 8387 +1
=======================================
+ Hits 6212 6213 +1
Misses 1570 1570
Partials 604 604
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to work around some interesting behavior from
DockerHub.
https://docs.docker.com/registry/spec/auth/token/#requesting-a-token
It would stand to reason that we shouldn't specify scope multiple times
if there is only one (space-separated) scope in the header.