Add unit test covering .dockerconfigjson secrets #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1335 +/- ##
=======================================
Coverage 74.16% 74.16%
=======================================
Files 114 114
Lines 8459 8459
=======================================
Hits 6274 6274
Misses 1579 1579
Partials 606 606 Continue to review full report at Codecov.
|
|
This Pull Request is stale because it has been open for 90 days with |
imjasonh
force-pushed
the
dockerconfigjson-test
branch
from
42e1e82
to
8dbf92d
Compare
jonjohnsonjr
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't previously covered, and better tests seem like they might help us narrow down the cause of knative/serving#12761
cc @dprotaso