-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate transport.New #1337
Deprecate transport.New #1337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
c666aa7
to
3f270eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1337 +/- ##
==========================================
- Coverage 74.07% 73.38% -0.69%
==========================================
Files 112 115 +3
Lines 8385 8747 +362
==========================================
+ Hits 6211 6419 +208
- Misses 1570 1687 +117
- Partials 604 641 +37
|
This Pull Request is stale because it has been open for 90 days with |
Merging this; @jonjohnsonjr if you have any other changes you'd like to make feel free to send a PR (or make me do it) Thanks for doing this @benmoss! 👍 |
Not sure if there was something @jonjohnsonjr was waiting on to deprecate this