Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate transport.New #1337

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Apr 8, 2022

Not sure if there was something @jonjohnsonjr was waiting on to deprecate this

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #1337 (3f270eb) into main (efc62d8) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   74.07%   73.38%   -0.69%     
==========================================
  Files         112      115       +3     
  Lines        8385     8747     +362     
==========================================
+ Hits         6211     6419     +208     
- Misses       1570     1687     +117     
- Partials      604      641      +37     
Impacted Files Coverage Δ
pkg/v1/remote/transport/transport.go 95.83% <ø> (-4.17%) ⬇️
pkg/v1/remote/check.go 70.00% <100.00%> (ø)
pkg/crane/options.go 78.26% <0.00%> (-7.46%) ⬇️
pkg/v1/remote/transport/useragent.go 41.17% <0.00%> (-5.89%) ⬇️
pkg/v1/google/keychain.go 87.50% <0.00%> (-2.50%) ⬇️
pkg/v1/remote/options.go 71.81% <0.00%> (-2.23%) ⬇️
pkg/v1/remote/mount.go 73.91% <0.00%> (-1.77%) ⬇️
pkg/crane/pull.go 68.11% <0.00%> (-1.33%) ⬇️
pkg/v1/remote/write.go 63.73% <0.00%> (-1.09%) ⬇️
... and 12 more

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@imjasonh imjasonh closed this Jul 19, 2022
@imjasonh imjasonh reopened this Jul 19, 2022
@imjasonh
Copy link
Collaborator

Merging this; @jonjohnsonjr if you have any other changes you'd like to make feel free to send a PR (or make me do it)

Thanks for doing this @benmoss! 👍

@imjasonh imjasonh merged commit f79ec21 into google:main Jul 19, 2022
@benmoss benmoss deleted the deprecate-transport-new branch August 1, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants