Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crane): add --allow-nondistributable-artifacts option to allow pushing non-distributable layers #1348

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

jwhb
Copy link
Contributor

@jwhb jwhb commented Apr 13, 2022

Since #930 non-distributable layers can be pushed by setting an option.

This PR exposes this option (--allow-nondistributable-artifacts) to crane command.

@google-cla
Copy link

google-cla bot commented Apr 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@jonjohnsonjr
Copy link
Collaborator

Thanks! Can you run ./hack/update-codegen.sh to update the docs for the presubmit?

@jwhb
Copy link
Contributor Author

jwhb commented Apr 13, 2022

Done. Should have RTFM :)

@codecov-commenter
Copy link

Codecov Report

Merging #1348 (175d12c) into main (2042cc9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 175d12c differs from pull request most recent head b32a15e. Consider uploading reports for the commit b32a15e to get more accurate results

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   74.07%   74.03%   -0.04%     
==========================================
  Files         112      112              
  Lines        8385     8389       +4     
==========================================
  Hits         6211     6211              
- Misses       1570     1574       +4     
  Partials      604      604              
Impacted Files Coverage Δ
pkg/crane/options.go 78.26% <0.00%> (-7.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2042cc9...b32a15e. Read the comment docs.

@jwhb jwhb changed the title feat(crane): add option to allow pushing non-distributable layers feat(crane): add --allow-nondistributable-artifacts option to allow pushing non-distributable layers Apr 18, 2022
@jonjohnsonjr
Copy link
Collaborator

Sorry, can you re-push this to make the github checks run again? I can't figure out how to rerun them :(

Signed-off-by: jwiegratz <jasper.wiegratz@sva.de>
Signed-off-by: jwhb <jwhy@jwhy.de>
@jwhb
Copy link
Contributor Author

jwhb commented Jun 21, 2022

@jonjohnsonjr done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants