Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump require blocks to point to latest main (892d7a8) #1351

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Apr 14, 2022

This is necessary for the authn/k8schain to pick up #1349 and #1350

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #1351 (e0a6d6b) into main (892d7a8) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
- Coverage   74.21%   74.19%   -0.03%     
==========================================
  Files         113      113              
  Lines        8439     8439              
==========================================
- Hits         6263     6261       -2     
- Misses       1572     1574       +2     
  Partials      604      604              
Impacted Files Coverage Δ
pkg/v1/remote/multi_write.go 62.92% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892d7a8...e0a6d6b. Read the comment docs.

@dprotaso
Copy link
Contributor Author

ugh - I ran tidy

@dprotaso
Copy link
Contributor Author

pre-submit worked :)

failure seems docker related

docker: Error response from daemon: process 6548 in container 337d7b45febf0eb1568c992d581dc4ca1057553865fe142f68d81b46b28cd00b encountered an error during hcsshim::Process::StdioLegacy: hcsshim: the handle has already been closed.

@imjasonh imjasonh merged commit 570ba6c into google:main Apr 14, 2022
@dprotaso dprotaso deleted the bump-go-mods branch April 14, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants